Drop default plugins "form", "typography", and "container-queries" #446
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taking care to fix up the form styling.
|
Happy to see these go. As long as everything from Tailwind UI remains copy/paste. I think that was probably the original intention behind adding these default plugins. That they were/thought to be required for Tailwind UI. So if they're getting in the way of that, good to dump. |
|
Released in v3.1.0: Release v3.1.0 / 2024-12-29 · rails/tailwindcss-rails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typography and container queries aren't used by this gem directly.
The form plugin is used, but I've attempted to complete styling of the generator template forms without it (though there may still be some differences due to the absence of style reset).
See #443 and #441 for examples of users getting poor rendering due to conflicts between Tailwind UI and the form plugin.
@dhh Really it's up to you whether this kind of minimalism is in line with your vision for the gem? It does seem like some developers and designers want to start from a vanilla initialization that matches what other tailwindcss tools do (Vite, CDN).
Some alternative approaches are also discussed in the comments in #443.