Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lazy load hooks documentation. #25784

Closed
kaspth opened this issue Jul 11, 2016 · 5 comments
Closed

Fix lazy load hooks documentation. #25784

kaspth opened this issue Jul 11, 2016 · 5 comments

Comments

@kaspth
Copy link
Contributor

kaspth commented Jul 11, 2016

Active Support has long had load hooks in https://github.com/rails/rails/blob/39b8b8fdbf6c175a64f07198ff1c950e33c72cd0/activesupport/lib/active_support/lazy_load_hooks.rb, but since 7c90d91 the docs stopped showing up on http://api.rubyonrails.org/files/activesupport/lib/active_support/lazy_load_hooks_rb.html.

Your mission, should you choose to accept it, is to fix this. We could wrap the file's behavior in a module and extend Active Support with it inline.

Then for good measure we should give the docs some housekeeping. Try coming up with a better explanation for why the lazy load hooks exist. Use this as a starting ground: rails/rails-controller-testing#24 (comment)

@mrageh
Copy link
Contributor

mrageh commented Jul 11, 2016

@kaspth I'll pick this up

@kaspth
Copy link
Contributor Author

kaspth commented Jul 11, 2016

Sweet!

@vipulnsward
Copy link
Member

@kaspth I believe this can be closed?

@mrageh
Copy link
Contributor

mrageh commented Jul 14, 2016

@vipulnsward I'd like to add another commit that improves the docs around load hooks

@kaspth
Copy link
Contributor Author

kaspth commented Jul 14, 2016

Yeah, this still encompasses a doc upgrade. So let's keep it open for now.

@mrageh you can add "Fixes #25784" in your PR and then this issue will auto-close when we merge that. Less work for us, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants