Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing notes on installing gc patched 1.8.x/1.9 #17

Merged
merged 2 commits into from
Jul 2, 2015

Conversation

nruth
Copy link
Contributor

@nruth nruth commented Jul 1, 2015

At time of writing this would have been useful related information, but Ruby 2 happened, and I don't think it's pertinent documentation for this gem.

At time of writing this would have been useful related information, but Ruby 2 happened, and I don't think it's pertinent documentation for this gem.
@senny
Copy link
Member

senny commented Jul 2, 2015

I'm 👍 on this change. However since rails-perftest still works with Rails versions that don't dictate Ruby 2.0 let's leave a small note pointing to an older revision of that README. This way people can still get to that information but we don't clutter the whole README for most users.

@nruth
Copy link
Contributor Author

nruth commented Jul 2, 2015

How's that? I left it in the same place with similar title incase anyone's expecting it to be in the same place. It could probably go to the bottom or something though, as it's a bit of a distraction. But fewer pages of distraction than before :)

senny added a commit that referenced this pull request Jul 2, 2015
Removing notes on installing gc patched 1.8.x/1.9
@senny senny merged commit 9504177 into rails:master Jul 2, 2015
@senny
Copy link
Member

senny commented Jul 2, 2015

👍

@senny
Copy link
Member

senny commented Jul 2, 2015

thank you 💛

@nruth nruth deleted the cut-building-ruby1.8-from-readme branch July 2, 2015 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants