bin/dev
fails to install Foreman in specific circumstances
#65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this might be an unexpected edge case, but I would expect it to become more common as time passes and people using jsbundling-rails update to new versions of Ruby.
Here's the scenario:
rbenv
to manage Ruby versions.bin/dev
. It will install Foreman "globally". (actually, it looks likerails new
should have, but it installed again when I ranbin/dev
)~/.rbenv/shims/foreman
(which is going to cause problems, becausebin/dev
relies on the command not existing)foreman
is not in the Gemfile.foreman
command is in my path:foreman
is not installed. Runningbin/dev
, orforeman
, raises the following error:command -v foreman
, it looks like relying ongem
is a better bet:As the script relies on
gem
anyway to install Foreman, using it to check if Foreman is installed beforehands does not seem like a big deal?