-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test installer commands #182
Changes from all commits
88078d9
cc6acf4
2042623
cd723a6
57d4db6
be1afa7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
name: CI | ||
on: [push, pull_request] | ||
jobs: | ||
tests: | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
ruby-version: | ||
- "3.1" | ||
- "3.2" | ||
- "3.3" | ||
gemfile: | ||
- gemfiles/rails_7_0.gemfile | ||
- gemfiles/rails_7_1.gemfile | ||
- gemfiles/rails_main.gemfile | ||
continue-on-error: [ false ] | ||
|
||
name: ${{ format('Tests (Ruby {0}, {1})', matrix.ruby-version, matrix.gemfile) }} | ||
runs-on: ubuntu-latest | ||
continue-on-error: ${{ matrix.continue-on-error }} | ||
|
||
env: | ||
BUNDLE_GEMFILE: ${{ matrix.gemfile }} | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Remove Gemfile lock | ||
run: | | ||
rm -f $BUNDLE_GEMFILE.lock | ||
|
||
- name: Install Ruby | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: ${{ matrix.ruby-version }} | ||
bundler-cache: true | ||
|
||
- name: Run tests | ||
run: | | ||
bundle exec rake |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,6 @@ | ||
/tmp/ | ||
.byebug_history | ||
*.gem | ||
|
||
# Ignore Gemfile.lock files for Rails main branch. | ||
/gemfiles/rails_main*.gemfile.lock |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
appraise "rails_7_0" do | ||
gem "rails", "~> 7.0.0" | ||
gem "propshaft" | ||
end | ||
|
||
appraise "rails_7_1" do | ||
gem "rails", "~> 7.1.0" | ||
gem "propshaft" | ||
end | ||
|
||
appraise "rails_main" do | ||
gem "rails", github: "rails/rails", branch: "main" | ||
gem "propshaft" | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,9 +4,9 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" } | |
# Specify your gem's dependencies in importmap-rails.gemspec. | ||
gemspec | ||
|
||
rails_version = ENV["RAILS_VERSION"] || "6.1.0" | ||
gem "rails", "~> #{rails_version}" | ||
|
||
gem "appraisal" | ||
gem "rails", "~> 6.0.0" | ||
Comment on lines
-7
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file defaulted the Rails version to 6.1, but the gemspec specifies 6.0. Which is correct? (Or do we want to jump to Rails 7.0?) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe we should retain compatibility with 6.0. |
||
gem "sprockets-rails" | ||
gem "sqlite3" | ||
|
||
group :test do | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only tests with Rails >= 7.0 and Ruby >= 3.1. I can add entries for Rails 6.0 and 6.1, and older versions of Ruby, but first I wanted to confirm which versions we want to support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to focus on these for now.