Check assets:precompile is defined before enhancing #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HLFH
added a commit
to HLFH/cssbundling-rails
that referenced
this pull request
Jan 19, 2022
rails@a749ca2 suggests that "Sprockets is not a dependency", so we should not assume that the assets:precompile AND assets:clobber tasks will be defined. If it's not there, we should just skip enhancing it. Related to: rails#59
|
Same issue for assets:clobber. @dhh You can merge #71, close duplicate #72, and merge rails/jsbundling-rails#70 on |
dhh
pushed a commit
that referenced
this pull request
Jan 28, 2022
patrickm68
added a commit
to patrickm68/bundling-rails
that referenced
this pull request
Dec 1, 2022
rails/cssbundling-rails@a749ca2 suggests that "Sprockets is not a dependency", so we should not assume that the assets:precompile AND assets:clobber tasks will be defined. If it's not there, we should just skip enhancing it. Related to: rails/cssbundling-rails#59
smartech7
pushed a commit
to smartech7/ruby-css-bundling
that referenced
this pull request
Aug 4, 2023
rails/cssbundling-rails@a749ca2 suggests that "Sprockets is not a dependency", so we should not assume that the assets:precompile AND assets:clobber tasks will be defined. If it's not there, we should just skip enhancing it. Related to: rails/cssbundling-rails#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a749ca2 suggests that "Sprockets is not a dependency", so we should not
assume that the assets:precompile task will be defined. If it's not
there, we should just skip enhancing it.
Fixes #58