Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable brotli compression in the caches_page #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable brotli compression in the caches_page #56

wants to merge 1 commit into from

Conversation

iggant
Copy link
Contributor

@iggant iggant commented May 3, 2019

No description provided.

@iggant iggant force-pushed the master branch 2 times, most recently from eb82e56 to e6aabc8 Compare May 10, 2019 16:12
rafaelfranca
rafaelfranca requested changes Dec 11, 2019
View reviewed changes
Copy link
Member

@rafaelfranca rafaelfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with brotli support but it should be optional. In the way it is implemented right now even people that don't want to use brotli will have to install the gem. Can you change the code to make it optional?

@navidemad
Copy link

Possible to merge it ? :)

@iggant iggant requested a review from rafaelfranca July 20, 2020 12:16
@iggant
Copy link
Contributor Author

iggant commented Jul 22, 2020

@rafaelfranca all done

@kinduff
Copy link

kinduff commented Jun 14, 2021

@rafaelfranca bumping this, would love to have it upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelfranca rafaelfranca Awaiting requested review from rafaelfranca

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iggant @navidemad @kinduff @rafaelfranca