Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining Json-API Adapter as Default #909

Merged
merged 3 commits into from
May 21, 2015

Conversation

joaomdmoura
Copy link
Member

As we decided, it's time to push JSON-API forward by making it the default adapter into AMS.
We really believe this is one of the greatest features into 0.10.x version, and that could help a lot of different projects from different technologies.
Despite of being a small change, we expect to see more people using it's conventions once we merge it.
@steveklabnik @guilleiguaran @kurko

@joaomdmoura joaomdmoura added this to the 0.10 milestone May 12, 2015
guilleiguaran added a commit that referenced this pull request May 21, 2015
Defining Json-API Adapter as Default
@guilleiguaran guilleiguaran merged commit f7fb4db into rails-api:master May 21, 2015
@joaomdmoura
Copy link
Member Author

@guilleiguaran o/

@guilleiguaran
Copy link
Member

@joaomdmoura \o

@spastorino
Copy link
Contributor

We would need to revert this in order to be able to use AMS by default in Rails. ❤️

@steveklabnik
Copy link
Contributor

This has changed?

@joaomdmoura
Copy link
Member Author

@steveklabnik we have just talked trough it on IRC.
You can check the conversation there but the idea is to make it easier to integrate with the usual JS frameworks around that are not using json api yet.
Ember is already moving forward with it, but the ideia would be to avoid push it at once but make it really easy to use.

@steveklabnik
Copy link
Contributor

:/

@steveklabnik
Copy link
Contributor

So, basically, the reason that JSON API should be the default is multifold, but one of the main ones is that convention over configuration is the heart of AMS.

You pick some kind of thing as the default, and so choosing an underspecified, ad-hoc old version doesn't make nearly as much sense to me. Classic AMS output was changed in JSON API because it isn't particularly great, a starting point.

joaomdmoura added a commit to joaomdmoura/active_model_serializers that referenced this pull request May 27, 2015
@joaomdmoura joaomdmoura mentioned this pull request May 27, 2015
joaomdmoura added a commit that referenced this pull request May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants