Fix namespace lookup for collections and has_many #1973
Conversation
|
@groyoh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @NullVoxPopuli and @bf4 to be potential reviewers. |
|
@NullVoxPopuli FYI |
| expected = { | ||
| 'title' => 'New Post', | ||
| 'body' => 'Body', 'writer' => nil, | ||
| "chapters"=>[ |
There was a problem hiding this comment.
some formatting here. Did you run rubocop?
There was a problem hiding this comment.
Turned out I ran it without git add'ing it :)
|
Just the formatting issue, and changelog entry needed. :-) then we can merge |
|
Sure thing! |
groyoh
force-pushed
the
fix_namespace_collection
branch
from
f7db7e2
to
47d1931
Compare
groyoh
force-pushed
the
fix_namespace_collection
branch
from
47d1931
to
7bfacf8
Compare
|
|
||
| class ChapterSerializer < ActiveModel::Serializer | ||
| attribute :title do | ||
| "Chapter - #{object.title}" |
There was a problem hiding this comment.
When AMS doesn't find the serializer it uses resource.as_json. So I added this "Chapter -" part, to make sure that we use the namespaced serializer instead of resource.as_json.
There was a problem hiding this comment.
I noticed that -- good thinkin'
|
@NullVoxPopuli fixed formatting and added CHANGELOG. |
Purpose
Due to the
CollectionSerializernot passing thenamespaceoption to the lookup, the namespace lookup doesn't work for collections and has_many relationships. This PR fixes it.Changes
Pass the
namespaceoption to the serializer lookup from theCollectionSerializer.Related GitHub issues
#1757 (comment)