-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read_attribute_for_serialization not seeing parent serializer methods #1661
Fix read_attribute_for_serialization not seeing parent serializer methods #1661
Conversation
@@ -189,7 +176,7 @@ def json_key | |||
end | |||
|
|||
def read_attribute_for_serialization(attr) | |||
if self.class._serializer_instance_method_defined?(attr) | |||
if respond_to?(attr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is waayyy simpler. interesting. Why was it so complicated before?
Thanks, I'll give this a go on my repo, and see how it fairs. |
I can confirm that this works |
|
ah, yep: http://grammarist.com/usage/fair-fare/ :-) |
I think it's helpful, depending on the tone. Cause it helps reduce my liklihood of being an idiot in the future |
…hods Fixes rails-api#1653, rails-api#1658, rails-api#1660 Define "scope_name" on instance singleton, not all instances
c6bcaab
to
6370e5c
Compare
Added changelog, rebased off of master, and squashed |
cool, I'll merge once CI passes |
Fixes #1653, #1658, #1660
Was introduced in #1650