Move ApiObjects to JsonApi namespace/folder

[groyoh]

Follow up to
https://github.com/rails-api/active_model_serializers/pull/1504/files#r52796473.
Moved the Relationship and ResourceIdentifier to the JsonApi
namespace/folder and slightly refactored the Relationship code.

[groyoh]

@bf4 following your comment I was not sure if they should still be namespace by ApiObjects or not.

[remear]

namespacing it under ApiObjects seems unnecessary to me.

[bf4]

Agreed. Under JsonApi is fine, see my errors pr

On Mon, Feb 22, 2016 at 9:56 PM Ben Mills [email protected] wrote:

In lib/active_model/serializer/adapter/json_api/relationship.rb
#1529 (comment)
:

@@ -0,0 +1,53 @@
+module ActiveModel

• class Serializer
• module Adapter

•  class JsonApi
  

•    class Relationship
  

namespacing it under ApiObjects seems unnecessary to me.

—
Reply to this email directly or view it on GitHub
https://github.com/rails-api/active_model_serializers/pull/1529/files#r53733792
.

[groyoh]

The tests files were not changed/moved because they would clash with some other test name (e.g. test/adapter/json_api/relationship_test.rb) so I kept them under test/adapter/json_api/api_objects folder.

[remear]

What if the tests from test/adapter/json_api/api_objects were merged into the files of the same name in the parent directory?

[groyoh]

And have two different group of tests in the same test file? I don't think that's appropriate. To be clear here test/adapter/json_api/relationship_test.rb tests the jsonapi adapter behavior when using relationship and test/adapter/json_api/api_objects/relationship_test.rb tests the relationship object itself.
Maybe there is a better solution here.

[remear]

Do you have a preference on how you'd like it to be structured?

[groyoh]

@remear not really. Any suggestion would be good to me. I would just not like to merge the two different concerns into the same file.

[groyoh]

@bf4 rebased on master and moved it to ActiveModelSerializers namespace.

[bf4]

Let's move these downs down a level and delete the api_objects directory

[groyoh]

Closing in favor of #1543