Fix options passing in Json and Attributes adapters #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
|
||
| def test_include_option | ||
| serializer = ArraySerializer.new([@first_post, @second_post]) | ||
| adapter = ActiveModel::Serializer::Adapter::Json.new(serializer, include: '') |
There was a problem hiding this comment.
It disregarded the include option.
There was a problem hiding this comment.
It did so every time for the Json adapter, and only for collections for the Attribute adapter.
There was a problem hiding this comment.
Ok, but when it failed, how was the output different? (lazy me)
There was a problem hiding this comment.
It did include stuff, although it was explicitly told not to.
NullVoxPopuli
added a commit
that referenced
this pull request
Sep 21, 2015
Fix options passing in Json and Attributes adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1184, there are issues with the way options are passed between adapters. This PR adds a failing test and provides fixes.