Use unstable contract env for development env #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of raiden-network/light-client#2521 Merge at the same time as raiden-network/raiden-services#951.
palango
approved these changes
Apr 1, 2021
|
|
||
| def __post_init__(self): | ||
| self.eth_rpc_endpoint_iterator = itertools.cycle(self.eth_rpc_endpoints) | ||
| self.development_environment = ContractDevEnvironment(self.development_environment) |
There was a problem hiding this comment.
Is this explicit cast necessary?
There was a problem hiding this comment.
This allows calling EnvironmentConfig(**json.load(...)) directly. Without it, you would have to explicitly convert the "unstable" string to EnvironmentConfig("unstable"), first. That would work too, but this way the JSON file and the EnvironmentConfig can be seen as the same thing more easily.
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "environment_type": "development", | |||
| "development_environment": "unstable", | |||
There was a problem hiding this comment.
Should we define this in the other files as well, just for consistency?
There was a problem hiding this comment.
Since the default choice is the right one for all environments but this one, I prefer to leave it out. It could just cause confusion with the similarly named "environment_type".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of raiden-network/light-client#2521
Merge after raiden-network/raiden-services#951 and configuring
*.services-dev.raiden.network/to use the unstable env.