Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate changes of #238 into test fixtures. #260

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

deepbrook
Copy link

@deepbrook deepbrook commented Aug 22, 2019

We also had to update the min balance and max funding constants for custom tokens, as those would otherwise trigger an exception when using all default values.

@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@c260ea9). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #260   +/-   ##
======================================
  Coverage       ?   58.54%           
======================================
  Files          ?       64           
  Lines          ?     3141           
  Branches       ?        0           
======================================
  Hits           ?     1839           
  Misses         ?     1302           
  Partials       ?        0
Impacted Files Coverage Δ
scenario_player/utils/configuration/settings.py 93.97% <100%> (ø)
scenario_player/constants.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c260ea9...19d73e7. Read the comment docs.

@deepbrook deepbrook merged commit 8ebffc6 into dev Aug 22, 2019
deepbrook pushed a commit that referenced this pull request Aug 23, 2019
@deepbrook deepbrook deleted the FIX-238-broken-harness branch October 29, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant