Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UDC balance_per_node and max_funding yaml options. #221

Merged
merged 4 commits into from
Aug 14, 2019

Conversation

deepbrook
Copy link

@deepbrook deepbrook commented Aug 13, 2019

Implements feature as requested per #218 :

2 new keys are available in the udc section of the yaml file:

settings:
  services:
    udc:
      enable: true
      token:
        deposit: true
        # The number of RDN/UDC Tokens required by each node
        balance_per_node: 5000
        # The maximum funding amount to deposit - defaults to `balance_per_node` if not given.
        max_funding: 5000

@deepbrook deepbrook changed the base branch from master to dev August 13, 2019 14:06
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@3ddbdc4). Click here to learn what that means.
The diff coverage is 90.47%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #221   +/-   ##
======================================
  Coverage       ?   51.84%           
======================================
  Files          ?       62           
  Lines          ?     3061           
  Branches       ?        0           
======================================
  Hits           ?     1587           
  Misses         ?     1474           
  Partials       ?        0
Impacted Files Coverage Δ
scenario_player/runner.py 28.43% <0%> (ø)
scenario_player/utils/configuration/settings.py 93.33% <100%> (ø)
scenario_player/utils/token.py 92.48% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ddbdc4...3b62117. Read the comment docs.

@deepbrook deepbrook force-pushed the FEAT-218-UDC-Mint-Options branch from db788a2 to e2b5a34 Compare August 13, 2019 14:07
@deepbrook deepbrook changed the title Implement UDC node_balance and max_funding yaml options. Implement UDC balance_per_node and max_funding yaml options. Aug 13, 2019
Copy link
Contributor

@czepluch czepluch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If my comment is too nitpicky please merge without fixing.

scenario_player/runner.py Outdated Show resolved Hide resolved
scenario_player/runner.py Outdated Show resolved Hide resolved
@deepbrook deepbrook merged commit f3b93f3 into dev Aug 14, 2019
@deepbrook deepbrook deleted the FEAT-218-UDC-Mint-Options branch August 14, 2019 06:19
@christianbrb
Copy link
Contributor

@nlsdfnbch Is this backward compatible -> does the old functionality still works or do we need to adjust the scenarios?

At the moment nodes seem to get 1000 Test-RDN Rai tokens at the start of a scenario when udc is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants