Fix PyInstaller bundling #7064
Merged
Fix PyInstaller bundling #7064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our bundled binaries seem to have been not working for some time. We had two separate issues: - The `av` dependency (via `aiortc`) wasn't being properly discovered by PyInstaller. This has been fixed with a hook. - On Linux stripping of the libraries apparently causes some corruption See: pypa/manylinux#119 Therefore stripping is disabled for now. - The gevent runtime hook would attempt to start the aio event loop. This caused a warning about an already running loop. This also fixes: - Don't include unnecessary av libraries in the bundle - Remove no longer used GETH_URL and SOLC_URL build args from the `bundle-docker` make target. - On CI: Invoke the built binaries with `--help` as a minimal functionality sanity check.
ulope
force-pushed
the
fix/bundle-creation
branch
from
a8d1f1f to
09ee03e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our bundled binaries seem to have been not working for some time (thanks @netcriptus for noticing).
We had two separate issues:
avdependency (viaaiortc) wasn't being properly discovered by PyInstaller.This has been fixed with a hook.
See: stripping some manylinux generated files produces broken shared objects pypa/manylinux#119
Therefore stripping is disabled for now.
This also fixes:
bundle-dockermake target.--helpas a minimal functionality sanity check.