Fix install-dev make target with new pip versions #6722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pip >= 20.3` is using a new resolver that no longer accepts extras in constraints files. In the `install-dev` task we used to pass our requirements-dev.txt file verbatim as a constraints file to ensure additional local developer tools (via `requirerments-local.txt`) don't cause breakage. For now pre-process the requirements file with sed to remove extras. See: pypa/pip#9209
ulope
added
Component / Tooling
eorituz
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pip >= 20.3is using a new resolver that no longer accepts extras in constraints files.In the
install-devtask we used to pass our requirements-dev.txt file verbatim as a constraints file to ensure additional local developer tools (viarequirerments-local.txt) don't cause breakage.For now pre-process the requirements file with sed to remove extras.
See: pypa/pip#9209