Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Endpoint to shutdown raiden #6113

Closed
1 task
fredo opened this issue May 4, 2020 · 2 comments · Fixed by #6118
Closed
1 task

Add API Endpoint to shutdown raiden #6113

fredo opened this issue May 4, 2020 · 2 comments · Fixed by #6118
Assignees
Labels
Component / API Issues that relate the the APIs Raiden provides. Effort / 2 very easy Flag / Usability Type / Enhancement

Comments

@fredo
Copy link
Contributor

fredo commented May 4, 2020

Abstract

If Raiden is started other than the CLI it might be difficult to shutdown Raiden easily (especially for non-technical users). This could happen if Raiden is started by the wizard.

Motivation

Non-technical users are controling raiden by some UI (e.g. the WebUI). The user should be able to shut raiden down via an exposed endpoint in order to have a controlled shutdown.

Specification

  • Provide an RestAPI Endpoint to shut raiden down gracefully
  • Take security measures into account that not everybody can shutdown the node
@karlb
Copy link
Contributor

karlb commented May 5, 2020

We could print a shutdown code as a parameter for the WebUI, e.g. http://localhost:5001/#shutdown_code=ADHLnecai2321. Then the WebUI can send that back when calling the shutdown.

But it seems wrong to me to protect a shutdown call more strictly than payment calls, since the latter is a more interesting target for malicious uses. It could also suggest to people the REST API is protected in some way.

Therefore I would leave the protection out and just ask people nicely not to shut down nodes in a workshop setting (and/or maybe restart then automatically on exit).

@ulope
Copy link
Collaborator

ulope commented May 5, 2020

Although I originally brought this up, the discussion we had in the standup call convinced me that we should just add the plain endpoint for now and then think about proper API access controls after the release.

@karlb karlb added the Effort / 2 very easy label May 7, 2020
karlb added a commit that referenced this issue May 11, 2020
This can then be used in the WebUI.

Closes #6113.
hackaugusto pushed a commit that referenced this issue May 29, 2020
This can then be used in the WebUI.

Closes #6113.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component / API Issues that relate the the APIs Raiden provides. Effort / 2 very easy Flag / Usability Type / Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants