-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mediation fee to spec and docs #4696
Comments
I took the relevant parts of the mediation fee ADR https://github.com/raiden-network/raiden-services/blob/master/adr/003-mediation-fees.md and adapted it a bit to fit into the existing mediation fee page. For the reasoning why we do it this way I just link to the ADR. We're still missing the specification of the message format. I've added that to raiden-network/raiden#4696.
I took the relevant parts of the mediation fee ADR https://github.com/raiden-network/raiden-services/blob/master/adr/003-mediation-fees.md and adapted it a bit to fit into the existing mediation fee page. For the reasoning why we do it this way I just link to the ADR. We're still missing the specification of the message format. I've added that to raiden-network/raiden#4696.
@karlb is this up to date now? Can we close? |
The spec is up to date. I'm not sure what the expectations for the user docs are. |
UPDATE For the docs, the goal is that the user understands that some payments are not working due to the fees involved. Secondary, we can try to tell the user how fees are to be changed and set. |
@agatsoh and me we were both irritated in recent tests due to the fees. We tried to send very small amounts and we got |
I think explaining it only goes so far. If the UX of this is so bad, that even people who work with it don't get it then we should maybe set them to zero for now and enable them only in a subsequent release. |
can we somehow only have default flat and proportional fees or have at least a better error message? |
How would that solve the problem? The problem is, to my understanding, that the default fees are way higher then the amount and we forbid this in the client. |
yes, my idea is that with only flat and proportional fees we can give the user a good error message by calculating that before the transfer is executed. Like it is easy to calculate
-> Just a thought, whereas we use the default values to calculate |
We definitively need a better error message. With that error message, no one is going look up the mediation fee chapter in the docs. At some point, we should also allow sending such payments if the user really wants. I agree that we should do something about it, but adding explanations to the mediation fee chapter won't help just by itself. So I consider it out of scope of this ticket. |
I created #6197, as this needs at least a code change for the error message. |
That's nice, but it would also be ice to still allow small amounts in direct transfers. |
Currently we have to user docs explaining how mediation fees work and how to set them.
PFSFeeUpdate
message (see PFS: Specify PFSFeeUpdate message spec#287)PFSCapacityUpdate
message (see PFS: Specify PFSCapacityUpdate message spec#288)The text was updated successfully, but these errors were encountered: