Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Make Goerli work again #275

Merged

Conversation

manuelwedler
Copy link
Contributor

This PR makes the new wizard usable on goerli testnet. It adds an selector on the first page to let the user choose to use Mainnet or Goerli.

@manuelwedler manuelwedler requested a review from fredo July 14, 2020 14:28
@manuelwedler manuelwedler changed the base branch from master to goerli-wizard July 14, 2020 14:30
@fredo
Copy link
Contributor

fredo commented Jul 14, 2020

Here is the code which we could get rid of with your pending transaction nonce change

def approve(w3, account, allowed_address, allowance: Wei, token: Erc20Token):

@manuelwedler
Copy link
Contributor Author

I'll add a commit for this change!

@fredo
Copy link
Contributor

fredo commented Jul 15, 2020

How complex would it be to change the Service Token Ticker to "SVT" when being on goerli? It is currently called RDN. To be copmpliant with the naming of the actual contract it would be nicer to have it called SVT (and to not be confused).

I see changes necessary in tokens.py and raiden-wizard/resources/conf/goerli.toml

@manuelwedler
Copy link
Contributor Author

Yes you are right, that would be much nicer. I think it could be easy. I will try it.

@fredo
Copy link
Contributor

fredo commented Jul 15, 2020

Thanks a lot!

Copy link
Contributor

@fredo fredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! thanks for the changes

@fredo fredo merged commit 61fe477 into raiden-network:goerli-wizard Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants