Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically install solc via solcx #1452

Closed
wants to merge 2 commits into from

Conversation

karlb
Copy link
Contributor

@karlb karlb commented Apr 29, 2021

Developers won't have to manually install solc, anymore.

Developers won't have to manually install solc, anymore.
This is done automatically by solcx
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #1452 (b7585ef) into master (e7dec86) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head b7585ef differs from pull request most recent head 207b8e2. Consider uploading reports for the commit 207b8e2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
+ Coverage   80.61%   80.65%   +0.03%     
==========================================
  Files          22       22              
  Lines        1558     1561       +3     
  Branches      190      190              
==========================================
+ Hits         1256     1259       +3     
  Misses        255      255              
  Partials       47       47              
Impacted Files Coverage Δ
raiden_contracts/contract_source_manager.py 94.38% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7dec86...207b8e2. Read the comment docs.

@karlb
Copy link
Contributor Author

karlb commented Apr 29, 2021

@palango Do you have an idea why the second commit makes the solium installation fail?

I could just remove 207b8e2, but I would like to understand this first. One explanation would be that solium relies on an installed solc, but I saw this neither in the error message nor in the solium docs.

@palango
Copy link
Contributor

palango commented Apr 29, 2021

@palango Do you have an idea why the second commit makes the solium installation fail?

No, doesn't make much sense from my pov either.

@karlb
Copy link
Contributor Author

karlb commented Apr 29, 2021

PR with only the first commit is #1453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants