Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforces kebab-case in component names #599

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Enforces kebab-case in component names #599

merged 1 commit into from
Nov 26, 2019

Conversation

kelsos
Copy link
Contributor

@kelsos kelsos commented Nov 26, 2019

No description provided.

@kelsos kelsos requested a review from nephix November 26, 2019 16:34
@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #599 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #599   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files          86      86           
  Lines        3314    3314           
  Branches      751     751           
======================================
  Hits         3185    3185           
  Misses         78      78           
  Partials       51      51
Flag Coverage Δ
#dapp 92.99% <ø> (ø) ⬆️
#sdk 97.47% <ø> (ø) ⬆️
Impacted Files Coverage Δ
raiden-dapp/src/views/Channels.vue 92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1824f4b...baf1018. Read the comment docs.

Copy link
Contributor

@nephix nephix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay more rules :)

@kelsos
Copy link
Contributor Author

kelsos commented Nov 26, 2019

@nephix rules are good, especially the ones that are automatically enforced and fixable :D

@kelsos kelsos merged commit d55a0ef into raiden-network:master Nov 26, 2019
@kelsos kelsos deleted the enforce-kebab-case branch November 26, 2019 19:30
@LefterisJP
Copy link

I actually learned something. Had no idea that-this-is-kebab-case

@kelsos
Copy link
Contributor Author

kelsos commented Nov 26, 2019

@LefterisJP I knew it was called something but I didn't remember. I actually had to check vue's documentation for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants