Revert "make two disk parameter optional"

This reverts commit 8efad8c.
rahalan · Jul 2, 2024 · badb240 · badb240
1 parent 8efad8c
commit badb240
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/avm/res/compute/virtual-machine/main.bicep b/avm/res/compute/virtual-machine/main.bicep
@@ -1145,8 +1145,8 @@ type osDiskType = {
   @description('Optional. The disk name.')
   name: string?
 
-  @description('Optional. Specifies the size of an empty data disk in gigabytes.')
-  diskSizeGB: int?
+  @description('Required. Specifies the size of an empty data disk in gigabytes.')
+  diskSizeGB: int
 
   @description('Optional. Specifies how the virtual machine should be created.')
   createOption: 'Attach' | 'Empty' | 'FromImage'?
@@ -1159,15 +1159,15 @@ type osDiskType = {
 
   @description('Required. The managed disk parameters.')
   managedDisk: {
-    @description('Optional. Specifies the storage account type for the managed disk.')
+    @description('Required. Specifies the storage account type for the managed disk.')
     storageAccountType:
       | 'PremiumV2_LRS'
       | 'Premium_LRS'
       | 'Premium_ZRS'
       | 'StandardSSD_LRS'
       | 'StandardSSD_ZRS'
       | 'Standard_LRS'
-      | 'UltraSSD_LRS'?
+      | 'UltraSSD_LRS'
 
     @description('Optional. Specifies the customer managed disk encryption set resource id for the managed disk.')
     diskEncryptionSetResourceId: string?

diff --git a/avm/res/compute/virtual-machine/main.json b/avm/res/compute/virtual-machine/main.json
@@ -6,7 +6,7 @@
     "_generator": {
       "name": "bicep",
       "version": "0.26.54.24096",
-      "templateHash": "5878958605426596334"
+      "templateHash": "8007594709688742996"
     },
     "name": "Virtual Machines",
     "description": "This module deploys a Virtual Machine with one or multiple NICs and optionally one or multiple public IPs.",
@@ -139,9 +139,8 @@
         },
         "diskSizeGB": {
           "type": "int",
-          "nullable": true,
           "metadata": {
-            "description": "Optional. Specifies the size of an empty data disk in gigabytes."
+            "description": "Required. Specifies the size of an empty data disk in gigabytes."
           }
         },
         "createOption": {
@@ -193,9 +192,8 @@
                 "Standard_LRS",
                 "UltraSSD_LRS"
               ],
-              "nullable": true,
               "metadata": {
-                "description": "Optional. Specifies the storage account type for the managed disk."
+                "description": "Required. Specifies the storage account type for the managed disk."
               }
             },
             "diskEncryptionSetResourceId": {