Skip to content

Commit

Permalink
fix: Load balancer failed pipelines for WAF test. (Azure#2383)
Browse files Browse the repository at this point in the history
## Description

Closes Azure#2352 


[![avm.res.network.load-balancer](https://github.com/arnoldna/bicep-registry-modules/actions/workflows/avm.res.network.load-balancer.yml/badge.svg?branch=avm%2Fres%2Fnetwork%2Fload-balancer)](https://github.com/arnoldna/bicep-registry-modules/actions/workflows/avm.res.network.load-balancer.yml)

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->


[![avm.res.network.load-balancer](https://github.com/arnoldna/bicep-registry-modules/actions/workflows/avm.res.network.load-balancer.yml/badge.svg?branch=avm%2Fres%2Fnetwork%2Fload-balancer)](https://github.com/arnoldna/bicep-registry-modules/actions/workflows/avm.res.network.load-balancer.yml)

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [ X] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ X] Someone has opened a bug report issue, and I have included
"Closes #{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ X] Update to documentation

## Checklist

- [ X] I'm sure there are no other open Pull Requests for the same
update/change
- [ X] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ X] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: ChrisSidebotham-MSFT <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Erika Gressi <[email protected]>
  • Loading branch information
4 people authored Jun 15, 2024
1 parent 8cf03ea commit 047fa60
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 12 deletions.
14 changes: 12 additions & 2 deletions avm/res/network/load-balancer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ module loadBalancer 'br/public:avm/res/network/load-balancer:<version>' = {

### Example 5: _WAF-aligned_

This instance deploys the module with the minimum set of required parameters to deploy a WAF alligned internal load balancer.
This instance deploys the module with the minimum set of required parameters to deploy a WAF-aligned internal load balancer.


<details>
Expand All @@ -961,6 +961,11 @@ module loadBalancer 'br/public:avm/res/network/load-balancer:<version>' = {
{
name: 'privateIPConfig1'
subnetId: '<subnetId>'
zones: [
'1'
'2'
'3'
]
}
]
name: 'nlbwaf001'
Expand Down Expand Up @@ -1055,7 +1060,12 @@ module loadBalancer 'br/public:avm/res/network/load-balancer:<version>' = {
"value": [
{
"name": "privateIPConfig1",
"subnetId": "<subnetId>"
"subnetId": "<subnetId>",
"zones": [
"1",
"2",
"3"
]
}
]
},
Expand Down
4 changes: 2 additions & 2 deletions avm/res/network/load-balancer/backend-address-pool/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.170.59819",
"templateHash": "13778755355834790948"
"version": "0.28.1.47646",
"templateHash": "12599435098613045377"
},
"name": "Load Balancer Backend Address Pools",
"description": "This module deploys a Load Balancer Backend Address Pools.",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/network/load-balancer/inbound-nat-rule/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.170.59819",
"templateHash": "528968121052795299"
"version": "0.28.1.47646",
"templateHash": "18107219293143755407"
},
"name": "Load Balancer Inbound NAT Rules",
"description": "This module deploys a Load Balancer Inbound NAT Rules.",
Expand Down
12 changes: 6 additions & 6 deletions avm/res/network/load-balancer/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.170.59819",
"templateHash": "3911239041572011237"
"version": "0.28.1.47646",
"templateHash": "17024389124356297408"
},
"name": "Load Balancers",
"description": "This module deploys a Load Balancer.",
Expand Down Expand Up @@ -525,8 +525,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.170.59819",
"templateHash": "13778755355834790948"
"version": "0.28.1.47646",
"templateHash": "12599435098613045377"
},
"name": "Load Balancer Backend Address Pools",
"description": "This module deploys a Load Balancer Backend Address Pools.",
Expand Down Expand Up @@ -662,8 +662,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.170.59819",
"templateHash": "528968121052795299"
"version": "0.28.1.47646",
"templateHash": "18107219293143755407"
},
"name": "Load Balancer Inbound NAT Rules",
"description": "This module deploys a Load Balancer Inbound NAT Rules.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ module testDeployment '../../../main.bicep' = [
{
name: 'privateIPConfig1'
subnetId: nestedDependencies.outputs.subnetResourceId
zones: [
'1'
'2'
'3'
]
}
]
backendAddressPools: [
Expand Down

0 comments on commit 047fa60

Please sign in to comment.