Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud oss update #1

Closed
wants to merge 40 commits into from
Closed

cloud oss update #1

wants to merge 40 commits into from

Conversation

raghavdixit99
Copy link
Owner

Internal PR, tests passed . Tested locally on notebook , added markdown for cloud usage.

**kwargs: Any,
) -> None:
"""Init params."""
self._connection = lancedb.connect(uri)
if api_key is not None:
Copy link

@AyushExel AyushExel Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditions that we should we addressing are:

  • if uri is remote but api_key is not provided - raise error
  • if api_key is provided with local uri - Just warn that "api key provided with local uri. The data will be stored locally"
  • I think we should allow either passing the api_key param or just set the LANCEDB_API_KEY env var?

What do you think Qian?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AyushExel for last point - I am adding a logic to check if api_key is not provided then we check the OS.env variable , if thats not set then we raise an appropriate error.

raghavdixit99 and others added 28 commits April 12, 2024 23:55
@raghavdixit99 raghavdixit99 deleted the lance_cloud_integration branch May 24, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants