-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud oss update #1
Conversation
**kwargs: Any, | ||
) -> None: | ||
"""Init params.""" | ||
self._connection = lancedb.connect(uri) | ||
if api_key is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conditions that we should we addressing are:
- if uri is remote but api_key is not provided - raise error
- if api_key is provided with local uri - Just warn that "api key provided with local uri. The data will be stored locally"
- I think we should allow either passing the api_key param or just set the LANCEDB_API_KEY env var?
What do you think Qian?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AyushExel for last point - I am adding a logic to check if api_key is not provided then we check the OS.env variable , if thats not set then we raise an appropriate error.
…ama#12763) use none as default
…store/llama-index-storage-index-store-elasticsearch (run-llama#12784)
…re/llama-index-storage-docstore-elasticsearch (run-llama#12783)
…afe_retrieval/contributor-2 (run-llama#12782)
…afe_retrieval/contributor-1 (run-llama#12781)
…ex-llms-llamafile (run-llama#12780)
…dex-tools-passio-nutrition-ai (run-llama#12779)
…dex-tools-finance (run-llama#12774)
…f-private-simple-dataset (run-llama#12767)
…ma#12803) * use none as default * fix doc id * bump version
Internal PR, tests passed . Tested locally on notebook , added markdown for cloud usage.