-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"letter box" (S H P M R A) unwantedly moves in certain conditions #187
Comments
Looks like its the "keep visible" code using the wrong width. I'll commit a fix tomorrow. |
The indicator init() function was using the maximum window size rather than the size due to which indicators are active. Not only would this cause the window to briefly appear too large before shrinking, it would unnecessarily trigger the keep-on-screen code, and so move the window. In addition to the fix, the keep-on-screen code now only adjusts the x or y position by the minimum rather than resetting the position to the default. I'll consider using the move windows proportionally function for when the window is not in the default position.
Hopefully fixed. I might change the code further to use the move window proportionally function for when the window is not in the default location. I keep the widow position in the default location so @feeltheburn, would that be useful? |
Thanks... This appears to be working fine, the only movement now is if it's partly out of the window view, it'll move just enough to be in view, staying in the same expected place. Which is not an issue since there's no reason to have it partly out of window view. |
https://www.youtube.com/watch?v=WzbDCEwbae0
The scenario: Client is shrunk to its smallest possible option. I've removed all the letters except S and M (giggity). I moved the box to the top right of the window, just below where FPS gets shown.
0:03 in video, I click the chat button to go to chat view, then directly back to the normal view. On going back to normal view, the S and M move down to the very bottom center of the screen, over the buttons.
0:12 I repeat with it being in non-moveable mode. It still moves.
EDIT: It's the reduced number of LETTERS combined with being close to the right side of the window causing it.
If you reduce the letters to one or two, place the letter box in the middle of the client, you'll see when clicking into chat and back to normal view quickly repeatedly that the letter box between chat and main view briefly expands to the size it would be with all letters.
If this happens when it's positioned too close to the right side of the client window, it pops down to the bottom of the client.
Size of the client window doesn't matter, it's reproducable putting the letter box over the right-side bar with only a couple letters in view.
The text was updated successfully, but these errors were encountered: