[refactoring] refactoring code #480

zhyass · 2019-09-09T03:32:26Z

planner code has poor readability currently, we need refactoring the code.

The text was updated successfully, but these errors were encountered:

[summary] `executor` code has poor readability currently, we need refactoring the code. [test case] src/executor/executor_test.go src/executor/select_executor_test.go src/executor/union_executor_test.go src/executor/engine/join_engine_test.go src/executor/engine/merge_engine_test.go src/executor/engine/union_engine_test.go src/executor/engine/operator/aggregate_operator_test.go src/executor/engine/operator/limit_operator_test.go src/executor/engine/operator/orderby_operator_test.go [patch codecov] src/executor/select_executor.go 100% src/executor/union_executor.go 100% src/executor/engine/common.go 81.8% src/executor/engine/join_engine.go 92.1% src/executor/engine/merge_engine.go 92.5% src/executor/engine/merge_join.go 97.2% src/executor/engine/plan_engine.go 100% src/executor/engine/union_engine.go 85.7% src/executor/engine/operator/aggregate_operator.go 98.1% src/executor/engine/operator/limit_operator.go 100% src/executor/engine/operator/operator.go 78.6% src/executor/engine/operator/orderby_operator.go 83.3%

[summary] `executor` code has poor readability currently, we need refactoring the code. [test case] src/executor/executor_test.go src/executor/select_executor_test.go src/executor/union_executor_test.go src/executor/engine/join_engine_test.go src/executor/engine/merge_engine_test.go src/executor/engine/union_engine_test.go src/executor/engine/operator/aggregate_operator_test.go src/executor/engine/operator/limit_operator_test.go src/executor/engine/operator/orderby_operator_test.go [patch codecov] src/executor/select_executor.go 100% src/executor/union_executor.go 100% src/executor/engine/common.go 81.8% src/executor/engine/join_engine.go 96.0% src/executor/engine/merge_engine.go 97.5% src/executor/engine/merge_join.go 98.6% src/executor/engine/plan_engine.go 100% src/executor/engine/union_engine.go 95.2% src/executor/engine/operator/aggregate_operator.go 98.1% src/executor/engine/operator/limit_operator.go 100% src/executor/engine/operator/operator.go 85.7% src/executor/engine/operator/orderby_operator.go 95.8%

[summary] rename some objects.

[summary] Using CastToBool instead of judging value directly will make the result more accurate. [test case] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/depends/sqltypes/arithmetic_test.go [patch codecov] 96.9%

[summary] Using CastToBool instead of judging value directly will make the result more accurate. [test case] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/depends/sqltypes/arithmetic_test.go [patch codecov] 94.2%

[summary] rename some objects.

[summary] merge the filterTuple and joinTuple. [test case] src/planner/from_test.go src/planner/select_plan_test.go [patch codecov] 96.9%

[summary] rename some objects.

[summary] merge the filterTuple and joinTuple. [test case] src/planner/from_test.go src/planner/select_plan_test.go [patch codecov] 96.9%

[summary] `planner` code has poor readability currently, we need refactoring the code. [test case] src/planner/builder/aggregate_plan_test.go src/planner/builder/builder_test.go src/planner/builder/expr_test.go src/planner/builder/from_test.go src/planner/builder/limit_plan_test.go src/planner/builder/orderby_plan_test.go src/planner/builder/sqlparser_test.go src/planner/others_plan_test.go src/planner/planner_test.go src/planner/select_plan_test.go src/planner/union_plan_test.go [patch codecov] src/planner/builder 97.7% src/planner 95.8%

[summary] src/executor/engine/join_engine_test.go src/planner/builder/builder_test.go src/planner/builder/from_test.go src/planner/select_plan_test.go [patch codecov] src/planner/builder 97.8%

[summary] Refactor the joinnode code about tableFilter by using CloneExpr. [test case] src/executor/engine/join_engine_test.go src/planner/builder/builder_test.go src/planner/builder/from_test.go src/planner/select_plan_test.go [patch codecov] src/planner/builder 97.8%

[summary] Colname in having must be included in fields, meed check it in parseHaving. [test case] src/planner/builder/builder_test.go src/planner/builder/expr_test.go src/planner/select_plan_test.go [patch codecov] src/planner/builder 97.8%

[summary] Refactor the joinnode code about tableFilter by using CloneExpr. [test case] src/executor/engine/join_engine_test.go src/planner/builder/builder_test.go src/planner/builder/from_test.go src/planner/select_plan_test.go [patch codecov] src/planner/builder 97.8%

[summary] Colname in having must be included in fields, meed check it in parseHaving. [test case] src/planner/builder/builder_test.go src/planner/builder/expr_test.go src/planner/select_plan_test.go [patch codecov] src/planner/builder 97.8%

[summary] In vitess, the AST visitor has been restructured, these work are worthy of reference. The AST structs and interface implementations live in the ast.go, which is what the visitor generator reads to produce the visitor. The rest of the AST functionality, all methods belonging to structs and not implementing any interfaces, now live in ast_funcs.go. [test case] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/parse_test.go [patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast. 87.4% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_func.go 95.0% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/parser.go 90.9% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/sql.go 92.0%

zhyass · 2020-05-27T08:50:36Z

In vitess, the AST visitor has been restructured, these work are worthy of reference.
vitessio/vitess#5611

[summary] In vitess, the AST visitor has been restructured, these work are worthy of reference. The AST structs and interface implementations live in the ast.go, which is what the visitor generator reads to produce the visitor. The rest of the AST functionality, all methods belonging to structs and not implementing any interfaces, now live in ast_funcs.go. [test case] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/parse_test.go [patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 87.4% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_func.go 95.8% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/parser.go 90.9% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/sql.go 92.0%

[summary] Package visitorgen is responsible for taking the ast.go of Radon and producing visitor infrastructure for it. [test case] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/ast_walker_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/struct_producer_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/transformer_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/visitor_emitter_test.go [patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/ast_walker.go 80.0% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/sast.go 87.5% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/struct_producer.go 94.6% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/transformer.go 97.0% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/visitor_emitter.go 31.8%

[summary] Rewrite traverses a syntax tree recursively, starting with root, and calling pre and post for each node as described below. Rewrite returns the syntax tree, possibly modified. [test case] N/A [patch codecov] N/A

[summary] Remove old visitor and replace functionality, use rewriter as the new visitor. [test case] N/A [patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_func.go 94.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/rewriter.go 64.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/rewriter_api.go 84.6%

…adondb#480 [summary] Remove old visitor and replace functionality, use rewriter as the new visitor. [test case] N/A [patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_func.go 94.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/rewriter.go 64.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/rewriter_api.go 84.6%

…adondb#480 [summary] Remove old visitor and replace functionality, use rewriter as the new visitor. [test case] N/A [patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_funcs.go 94.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/rewriter.go 64.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/rewriter_api.go 84.6%

sqlparser: restructure the ast #480

zhyass · 2020-06-01T08:53:04Z

https://github.com/radondb/radon/blob/master/src/backend/txn.go#L445
https://github.com/golang/sync/tree/master/errgroup

	var mu sync.Mutex
	var wg sync.WaitGroup
        ... ...
	allErrors := make([]error, 0, 8)
        ... ...
		if x != nil {
			mu.Lock()
			allErrors = append(allErrors, x)
			mu.Unlock()
		}

We can use errorgroup.Group instead of WaitGroup.

[summary] Package errgroup provides synchronization, error propagation, and Context cancelation for groups of goroutines working on subtasks of a common task. We can use the errgroup to handle error under concurrency. [test case] N/A [patch codecov] N/A

[summary] Package errgroup provides synchronization, error propagation, and Context cancelation for groups of goroutines working on subtasks of a common task. We can use the errgroup to handle error under concurrency. [test case] N/A [patch codecov] src/backend/txn.go 89.8% src/backend/xa.go 91.1% src/executor/engine/join_engine.go 95.7% src/executor/engine/union_engine.go 93.9%

[summary] In vitess, the AST visitor has been restructured, these work are worthy of reference. The AST structs and interface implementations live in the ast.go, which is what the visitor generator reads to produce the visitor. The rest of the AST functionality, all methods belonging to structs and not implementing any interfaces, now live in ast_funcs.go. [test case] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/parse_test.go [patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 87.4% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_func.go 95.8% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/parser.go 90.9% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/sql.go 92.0%

[summary] Package visitorgen is responsible for taking the ast.go of Radon and producing visitor infrastructure for it. [test case] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/ast_walker_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/struct_producer_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/transformer_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/visitor_emitter_test.go [patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/ast_walker.go 80.0% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/sast.go 87.5% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/struct_producer.go 94.6% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/transformer.go 97.0% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/visitorgen/visitor_emitter.go 31.8%

[summary] Rewrite traverses a syntax tree recursively, starting with root, and calling pre and post for each node as described below. Rewrite returns the syntax tree, possibly modified. [test case] N/A [patch codecov] N/A

…480 [summary] Remove old visitor and replace functionality, use rewriter as the new visitor. [test case] N/A [patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_funcs.go 94.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/rewriter.go 64.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/rewriter_api.go 84.6%

[summary] Package errgroup provides synchronization, error propagation, and Context cancelation for groups of goroutines working on subtasks of a common task. We can use the errgroup to handle error under concurrency. [test case] N/A [patch codecov] src/backend/txn.go 89.8% src/backend/xa.go 91.1% src/executor/engine/join_engine.go 95.7% src/executor/engine/union_engine.go 93.9%

*: use errgroup to handle error under concurrency #480

[summary] partition_options: \* empty *\ | GLOBAL | SINGLE | DISTRIBUTED BY (backend-name) | PARTITION BY HASH(shard-key) {PARTITIONS num} | PARTITION BY LIST(shard-key)(PARTITION backend VALUES IN (value_list),...) [test case] src/proxy/ddl_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ddl_test.go [patch codecov] src/proxy/ddl.go 94.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_funcs.go 95.5% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/sql.go 92.3%

[summary] reference: https://dev.mysql.com/doc/refman/5.7/en/create-table.html CREATE TABLE [IF NOT EXISTS] tbl_name (create_definition,...) [table_options] [partition_options] partition_options: \* empty *\ | GLOBAL | SINGLE | DISTRIBUTED BY (backend-name) | PARTITION BY HASH(shard-key) {PARTITIONS num} | PARTITION BY LIST(shard-key)(PARTITION backend VALUES IN (value_list),...) [test case] src/proxy/ddl_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ddl_test.go [patch codecov] src/proxy/ddl.go 94.7% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_funcs.go 95.5% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/sql.go 92.3%

*: refactor partition definition #480

stale · 2020-07-31T09:24:36Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

zhyass added the type: refactoring Internal code refactoring label Sep 9, 2019

zhyass self-assigned this Sep 9, 2019

zhyass changed the title ~~[refactoring] refactoring planner code~~ [refactoring] refactoring code Sep 10, 2019

zhyass added a commit to zhyass/radon that referenced this issue Sep 10, 2019

executor: refactoring executor code radondb#480

3a112f4

zhyass added a commit to zhyass/radon that referenced this issue Oct 29, 2019

*: rename some objects radondb#480

c22f341

[summary] rename some objects.

zhyass added a commit to zhyass/radon that referenced this issue Oct 31, 2019

*: rename some objects radondb#480

a89b905

[summary] rename some objects.

zhyass added a commit to zhyass/radon that referenced this issue Oct 31, 2019

planner: refactor the filterTuple radondb#480

7774949

[summary] merge the filterTuple and joinTuple. [test case] src/planner/from_test.go src/planner/select_plan_test.go [patch codecov] 96.9%

zhyass mentioned this issue Oct 31, 2019

refactor the planner code #504

Merged

BohuTANG pushed a commit that referenced this issue Oct 31, 2019

*: rename some objects #480

d8578f8

[summary] rename some objects.

BohuTANG pushed a commit that referenced this issue Oct 31, 2019

planner: refactor the filterTuple #480

61723d6

[summary] merge the filterTuple and joinTuple. [test case] src/planner/from_test.go src/planner/select_plan_test.go [patch codecov] 96.9%

zhyass mentioned this issue May 27, 2020

sqlparser: restructure the ast #480 #642

Merged

BohuTANG added a commit that referenced this issue Jun 1, 2020

Merge pull request #642 from zhyass/feature_set

78bf663

sqlparser: restructure the ast #480

zhyass mentioned this issue Jun 1, 2020

*: use errgroup to handle error propagation #480 #643

Closed

zhyass mentioned this issue Jun 1, 2020

*: use errgroup to handle error under concurrency #480 #646

Merged

BohuTANG added a commit that referenced this issue Jun 2, 2020

Merge pull request #646 from zhyass/feature_show

a8d8031

*: use errgroup to handle error under concurrency #480

BohuTANG added a commit that referenced this issue Jun 8, 2020

Merge pull request #651 from zhyass/temp_join_fix

8112169

*: refactor partition definition #480

stale bot added the wontfix label Jul 31, 2020

stale bot closed this as completed Aug 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[refactoring] refactoring code #480

[refactoring] refactoring code #480

zhyass commented Sep 9, 2019

zhyass commented May 27, 2020

zhyass commented Jun 1, 2020 •

edited

Loading

stale bot commented Jul 31, 2020

[refactoring] refactoring code #480

[refactoring] refactoring code #480

Comments

zhyass commented Sep 9, 2019

zhyass commented May 27, 2020

zhyass commented Jun 1, 2020 • edited Loading

stale bot commented Jul 31, 2020

zhyass commented Jun 1, 2020 •

edited

Loading