Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix + update Rust version comments #2030

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

lrubasze
Copy link
Contributor

@lrubasze lrubasze commented Nov 27, 2024

  • Warn (instead of return error) when no tests to run for nextest
    (nextest changed default behaviour since version 0.9.85)
  • Update Rust version comments

Copy link

github-actions bot commented Nov 27, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:a91787d8bc

Copy link

github-actions bot commented Nov 27, 2024

Benchmark for a29d100

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.3±0.08ms 44.4±0.08ms +0.23%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.3±0.02ms 19.3±0.03ms 0.00%
costing::decode_encoded_i8_array_to_manifest_value 40.8±0.05ms 42.4±0.09ms +3.92%
costing::decode_encoded_tuple_array_to_manifest_raw_value 70.6±0.09ms 72.2±0.09ms +2.27%
costing::decode_encoded_tuple_array_to_manifest_value 115.9±1.02ms 98.9±0.14ms -14.67%
costing::decode_encoded_u8_array_to_manifest_raw_value 31.9±0.07µs 31.9±0.05µs 0.00%
costing::decode_encoded_u8_array_to_manifest_value 40.8±0.05ms 42.4±0.05ms +3.92%
costing::decode_rpd_to_manifest_raw_value 14.6±0.02µs 15.0±0.03µs +2.74%
costing::decode_rpd_to_manifest_value 11.0±0.02µs 11.2±0.01µs +1.82%
costing::deserialize_wasm 1206.6±4.38µs 1222.1±7.56µs +1.28%
costing::execute_transaction_creating_big_vec_substates 695.3±4.08ms 699.2±8.49ms +0.56%
costing::execute_transaction_reading_big_vec_substates 572.8±1.55ms 592.2±0.84ms +3.39%
costing::instantiate_flash_loan 865.7±385.74µs 988.7±968.29µs +14.21%
costing::instantiate_radiswap 1043.0±1945.05µs 963.2±766.81µs -7.65%
costing::scrypto_malloc 660.9±1.14ms 666.2±1.74ms +0.80%
costing::scrypto_sbor_decode 648.6±0.67ms 651.3±1.35ms +0.42%
costing::scrypto_sha256 586.7±0.83ms 581.5±0.94ms -0.89%
costing::spin_loop_v1 516.7±1.49ms 516.7±1.58ms 0.00%
costing::spin_loop_v2 594.3±3.98ms 598.2±8.58ms +0.66%
costing::validate_sbor_payload 29.6±0.05µs 29.7±0.11µs +0.34%
costing::validate_sbor_payload_bytes 261.3±2.88ns 271.3±6.68ns +3.83%
costing::validate_secp256k1 76.5±0.05µs 77.7±0.11µs +1.57%
costing::validate_wasm 33.4±0.03ms 33.5±0.03ms +0.30%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 328.1±2.02ns 325.9±1.13ns -0.67%
decimal::add/wasmi-call-native 2.9±0.00µs 2.9±0.00µs 0.00%
decimal::div/0 168.5±0.25ns 174.8±0.72ns +3.74%
decimal::from_string/0 156.3±0.10ns 156.6±0.19ns +0.19%
decimal::mul/0 127.6±0.11ns 129.6±0.06ns +1.57%
decimal::mul/rust-native 128.1±0.08ns 128.2±0.26ns +0.08%
decimal::mul/wasmi 19.7±0.03µs 19.6±0.03µs -0.51%
decimal::mul/wasmi-call-native 3.0±0.00µs 3.1±0.01µs +3.33%
decimal::pow/0 592.0±0.39ns 591.9±0.31ns -0.02%
decimal::pow/rust-native 590.0±0.33ns 589.9±0.16ns -0.02%
decimal::pow/wasmi 92.7±0.12µs 93.9±0.19µs +1.29%
decimal::pow/wasmi-call-native 4.8±0.01µs 4.8±0.01µs 0.00%
decimal::root/0 8.3±0.01µs 8.1±0.01µs -2.41%
decimal::sub/0 8.2±0.09ns 8.4±0.02ns +2.44%
decimal::to_string/0 445.6±0.28ns 442.0±0.58ns -0.81%
large_transaction_processing::prepare 2.5±0.00ms 2.6±0.00ms +4.00%
large_transaction_processing::prepare_and_decompile 6.2±0.02ms 6.1±0.02ms -1.61%
large_transaction_processing::prepare_and_decompile_and_recompile 29.8±2.16ms 25.8±1.50ms -13.42%
metadata_validation::validate_urls 4.8±0.02µs 4.9±0.10µs +2.08%
precise_decimal::add/0 8.9±0.01ns 8.7±0.01ns -2.25%
precise_decimal::add/rust-native 10.7±0.05ns 10.7±0.15ns 0.00%
precise_decimal::add/wasmi 426.8±1.90ns 424.3±3.05ns -0.59%
precise_decimal::add/wasmi-call-native 3.8±0.01µs 3.8±0.01µs 0.00%
precise_decimal::div/0 286.8±0.33ns 286.9±0.35ns +0.03%
precise_decimal::from_string/0 201.7±0.17ns 203.8±0.92ns +1.04%
precise_decimal::mul/0 329.5±0.30ns 328.7±0.45ns -0.24%
precise_decimal::mul/rust-native 286.4±0.24ns 285.9±0.35ns -0.17%
precise_decimal::mul/wasmi 48.5±0.28µs 48.0±0.15µs -1.03%
precise_decimal::mul/wasmi-call-native 4.1±0.01µs 4.2±0.01µs +2.44%
precise_decimal::pow/0 1730.1±4.77ns 1733.1±2.28ns +0.17%
precise_decimal::pow/rust-native 1353.5±1.28ns 1353.9±0.75ns +0.03%
precise_decimal::pow/wasmi 230.8±0.48µs 231.9±0.46µs +0.48%
precise_decimal::pow/wasmi-call-native 7.5±0.02µs 7.4±0.01µs -1.33%
precise_decimal::root/0 57.8±0.01µs 57.7±0.04µs -0.17%
precise_decimal::sub/0 9.2±0.05ns 9.0±0.06ns -2.17%
precise_decimal::to_string/0 696.1±1.34ns 728.5±3.42ns +4.65%
schema::validate_payload 386.6±0.49µs 387.2±0.57µs +0.16%
transaction::radiswap 4.9±0.03ms 4.9±0.02ms 0.00%
transaction::transfer 1784.1±2.78µs 1806.4±4.65µs +1.25%
transaction_validation::validate_manifest 43.0±0.03µs 43.1±0.14µs +0.23%
transaction_validation::verify_bls_2KB 965.6±10.44µs 950.8±5.40µs -1.53%
transaction_validation::verify_bls_32B 976.3±8.99µs 950.2±3.73µs -2.67%
transaction_validation::verify_ecdsa 74.4±0.05µs 74.4±0.07µs 0.00%
transaction_validation::verify_ed25519 42.2±0.07µs 42.2±0.08µs 0.00%

@lrubasze lrubasze changed the title Update Rust version comments Update Rust version comments + CI fix Nov 27, 2024
@lrubasze lrubasze changed the title Update Rust version comments + CI fix CI fix + update Rust version comments Nov 27, 2024
@lrubasze lrubasze changed the base branch from develop to release/cuttlefish November 27, 2024 18:28
@lrubasze lrubasze changed the base branch from release/cuttlefish to develop November 27, 2024 18:28
@lrubasze lrubasze changed the base branch from develop to release/cuttlefish November 27, 2024 18:30
@dhedey dhedey merged commit 72cba14 into release/cuttlefish Nov 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants