Add scrypto dev container target #2004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azizi-a
force-pushed
the
add-scrypto-dev-container
branch
from
8ff2571
to
5f14446
Compare
|
Docker tags |
azizi-a
force-pushed
the
add-scrypto-dev-container
branch
from
5f14446
to
3276dac
Compare
Benchmark for 0696ac2Click to view benchmark
|
dhedey
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Really nice!
Out of interest:
- How is this supposed to be used?
- Do people add some kind of devcontainer file to their repo?
- How can this be tested locally during development?
- How have you been testing it?
- Might we want some script to build the dev container locally, possibly commented in the Dockerfile to help future people to tweak it?
- Perhaps we need something in CI to test the building of this target? Like the dev-container equivalent of
ci-scrypto-builder.ymlandpublish-scrypto-builder.yml
Dockerfile
Outdated
| @@ -50,6 +50,13 @@ WORKDIR /app | |||
|
|
|||
| RUN cargo install --path ./radix-clis | |||
|
|
|||
| FROM base-image as dev-container | |||
| RUN apt install -y bash-completion powerline | |||
There was a problem hiding this comment.
Might be worth a quick comment explaining that this installs a better prompt for a better dev experience (with maybe a link to the powerline website?)
| RUN echo 'powerline-daemon -q; POWERLINE_BASH_CONTINUATION=1; POWERLINE_BASH_SELECT=1; . /usr/share/powerline/bindings/bash/powerline.sh; . /etc/bash_completion' >> ~/.bashrc | ||
| COPY --from=builder /app/target/release/scrypto /usr/local/bin/scrypto | ||
| COPY --from=builder /app/target/release/resim /usr/local/bin/resim | ||
| RUN rustup target add wasm32-unknown-unknown |
There was a problem hiding this comment.
I wonder if we want some kind of ENTRYPOINT line? Possibly not! What's standard for dev containers?
There was a problem hiding this comment.
The documentation shows no examples with an ENTRYPOINT
My intention is to create another repo with the Hello template in and that uses this image as it's dev container
Build the image with {
"name": "Radix Scrypto",
"image": "scrypto-dev-container",
"customizations": {
"vscode": {
"extensions": [
"rust-lang.rust-analyzer",
"tamasfe.even-better-toml",
"radixpublishing.radix-developer-tools"
]
}
}
}
That would be the same for the new repo also containing a Hello template
Will add this
Will add this too |
azizi-a
force-pushed
the
add-scrypto-dev-container
branch
from
cda17ea
to
44da993
Compare
azizi-a
force-pushed
the
add-scrypto-dev-container
branch
from
44da993
to
5aebfa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary