Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(context): add React.FC type in Provider #3080

Merged
merged 2 commits into from
Sep 27, 2024
Merged

refactor(context): add React.FC type in Provider #3080

merged 2 commits into from
Sep 27, 2024
+43 −8

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Aug 22, 2024 •
edited
Loading

Description

  • add React.FC type in Provider
    • just Function has not displayName type but React.FC has displayName type
    • make the format the same with CollectionProvider

@sukvvon
Copy link
Contributor Author

sukvvon commented Aug 26, 2024

@chaance in UI Tests, is there any problem?

@sukvvon sukvvon requested a review from chaance August 26, 2024 12:16
@chaance chaance merged commit ae51e9d into radix-ui:main Sep 27, 2024
4 of 5 checks passed
@sukvvon sukvvon deleted the refactor/useContext-Provider-FC branch September 27, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHaney StephenHaney Awaiting requested review from StephenHaney StephenHaney is a code owner

@vladmoroz vladmoroz Awaiting requested review from vladmoroz vladmoroz is a code owner

@lucasmotta lucasmotta Awaiting requested review from lucasmotta lucasmotta is a code owner

@hadihallak hadihallak Awaiting requested review from hadihallak hadihallak is a code owner

@chaance chaance Awaiting requested review from chaance chaance is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukvvon @chaance