Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] Improve performance #2855

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Dialog] Improve performance #2855

wants to merge 3 commits into from

Conversation

andresz1
Copy link

@andresz1 andresz1 commented Apr 19, 2024 •
edited
Loading

Description

This PR improves Dialog component INP performance by prioritising paint when modal prop is set to true

  • The style change over the body is now executed using a setTimeout to avoid doing synchronously before the paint.

Before

Screenshot 2024-04-19 at 12 03 15

After

Screenshot 2024-04-19 at 11 59 43

@andresz1 andresz1 changed the title Improve dialog performance [Dialog] Improve performance Apr 19, 2024
nucliweb
nucliweb approved these changes Apr 23, 2024
View reviewed changes
Copy link

@nucliweb nucliweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@RinNguyens
Copy link

👍

@chaance chaance added Resolution: Needs Investigation This issue needs more investigation and removed Needs Review labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikoruiz kikoruiz kikoruiz approved these changes

@andresin87 andresin87 andresin87 approved these changes

@nucliweb nucliweb nucliweb approved these changes

@benoitgrelard benoitgrelard Awaiting requested review from benoitgrelard

@andy-hook andy-hook Awaiting requested review from andy-hook

@vladmoroz vladmoroz Awaiting requested review from vladmoroz vladmoroz is a code owner

@lucasmotta lucasmotta Awaiting requested review from lucasmotta lucasmotta is a code owner

@StephenHaney StephenHaney Awaiting requested review from StephenHaney StephenHaney is a code owner

@hadihallak hadihallak Awaiting requested review from hadihallak hadihallak is a code owner

@chaance chaance Awaiting requested review from chaance chaance is a code owner

Assignees
No one assigned
Labels
Resolution: Needs Investigation This issue needs more investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andresz1 @RinNguyens @nucliweb @andresin87 @kikoruiz @chaance