[Storybook] Fix Collection stories #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitgrelard
commented
Dec 17, 2021
| @@ -157,7 +157,7 @@ const MemoItem = React.memo(Item); | |||
| const MemoItems = React.memo(WrappedItems); | |||
|
|
|||
| function LogItems({ name = 'items' }: { name?: string }) { | |||
| const getItems = useCollection({}); | |||
| const getItems = useCollection(undefined); | |||
There was a problem hiding this comment.
Basically, we were passing scope={undefined} everywhere on the component props, but here we were passing an empty object.
andy-hook
approved these changes
Dec 17, 2021
jjenzz
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst checking every story when working on #1048 I noticed all of the
Collectionstories were broken.Probably have been broken since we use the scoping of contexts, the scope wasn't matching in
useCollectionusage.