Fix inconsistency in CODEOWNERS files #8074
Comments
kachawla
added
the
maintenance
|
👋 @kachawla Thanks for filing this issue. A project maintainer will review this issue and get back to you soon. We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue. For more information on our triage process please visit our triage overview |
|
👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up. We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue. For more information on our triage process please visit our triage overview |
|
Discussed this during triage, the decision is to copy over latest owners groups from root level |
|
@willtsai PRs created in all the repos (referenced above). |
kachawla
changed the title
Combining two codeowners files into one, with root level pointing to the file under the .github directory. More context in radius-project/radius#8074. Signed-off-by: karishma-chawla <[email protected]> Co-authored-by: karishma-chawla <[email protected]>
Combining two codeowners files into one, with root level pointing to the file under the `.github` directory. More context in radius-project/radius#8074. Signed-off-by: karishma-chawla <[email protected]> Co-authored-by: karishma-chawla <[email protected]>
# Description Combining two codeowners files into one, with root level pointing to the file under the `.github` directory. More context in #8074. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #8074 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - [ ] An overview of proposed schema changes is included in a linked GitHub issue. -- N/A - [ ] A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. -- N/A - [ ] If applicable, design document has been reviewed and approved by Radius maintainers/approvers. -- N/A - [ ] A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. -- N/A - [ ] A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. -- N/A - [ ] A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. -- N/A Signed-off-by: karishma-chawla <[email protected]> Co-authored-by: karishma-chawla <[email protected]>
Area for Improvement
CODEOWNERS files for all repos under radius-project.
Observed behavior
We recently created/updated owners groups for each of the Radius repo and added top levels to reflect the information, for example: https://github.com/radius-project/design-notes/blob/main/CODEOWNERS. However, in some repos the groups are inconsistent with what was listed in the codeowners file located under
.githubdirectory, for example: https://github.com/radius-project/design-notes/blob/main/.github/CODEOWNERS.Desired behavior
We should update
.github/CODEOWNERSto match the latest state of owner groups listed in the repo levelCODEOWNERSfile.Proposed Fix
No response
rad Version
N/A
Operating system
No response
Additional context
No response
Would you like to support us?
AB#13725
The text was updated successfully, but these errors were encountered: