Remove old Radius RP prefixes from Kubernetes labels #5285
Labels
triaged
This issue has been reviewed and triaged
Comments
|
Should discuss with Karishma, RyanN, and Aaron to determine which labels should be deleted and which should be updated (to what values). |
|
@kachawla @AaronCrawfis , I am not sure which of the labels are to be deleted, or if I were to determine that as part of this story. |
These are the labels: https://github.com/project-radius/radius/blob/main/pkg/kubernetes/labels.go#L26-L47 We'll need to replace |
|
Thank you @AaronCrawfis , @kachawla , then would it make sense for me to hold this work until we decide if it should be radapp.dev? |
Yep let's hold on this for now and we can tackle once we get a confirmation on the domain name |
|
@AaronCrawfis - Did we get a confirmation on the domain name? |
Still waiting on one last potential option. Should know by next week, and if no luck we can proceed with |
|
triage: verified that we will use radapp.io |
willdavsmith
added a commit
that referenced
this issue
Oct 3, 2023
…io` (#6357) # Description * Replaced all instances of `radius.dev` with `radapp.io` * Replaced instances of `radapp.dev` with `radapp.io` only in swagger examples Recipes update: radius-project/recipes#33 ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (issue link required). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #5285 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at ef89e72</samp> ### Summary 🌐🏷️🧪 <!-- 1. 🌐 - This emoji represents the change of domain name from radius.dev to radapp.io, which is a global or internet-related change. 2. 🏷️ - This emoji represents the change of label names from radius.dev/* to radapp.io/*, which is a tagging or labeling change. 3. 🧪 - This emoji represents the change of test data to reflect the new domain and label names, which is a testing or experimentation change. --> This pull request updates the domain name, label names, and test data in various files to reflect the new branding and deployment of the Radius project as radapp.io. It affects the armrpc, corerp, and cli packages and their subpackages. It ensures consistency and compatibility between the code, the API, and the test cases. > _Oh we're the crew of the `radapp.io`_ > _And we're changing all the test data_ > _We'll heave away and haul away_ > _With every pull request we make_ ### Walkthrough * Replace the domain name radius.dev with radapp.io in referer, original URL, forwarded host, and location headers in test data and test cases ([link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-108beba9cce5ef691507d611bb2b6574bf43c7c3a6a5981fa9133ff28e213546L39-R39), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-108beba9cce5ef691507d611bb2b6574bf43c7c3a6a5981fa9133ff28e213546L49-R49), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-a69cf098fadbaa59139fb2c0e0ee95c0633da1eb0b16249a8b24f993f9802338L7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-a69cf098fadbaa59139fb2c0e0ee95c0633da1eb0b16249a8b24f993f9802338L17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-a69cf098fadbaa59139fb2c0e0ee95c0633da1eb0b16249a8b24f993f9802338L24-R24), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-9b3146f6353ade1d4494265f6647a225821a26f1388dabc6905306b0a4900604L7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-9b3146f6353ade1d4494265f6647a225821a26f1388dabc6905306b0a4900604L17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-9b3146f6353ade1d4494265f6647a225821a26f1388dabc6905306b0a4900604L24-R24), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-1f114f1f0706dfbeb6170ac054f09beb43f0c80a84b00ddaeea7bb5b8755d5a4L7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-1f114f1f0706dfbeb6170ac054f09beb43f0c80a84b00ddaeea7bb5b8755d5a4L17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-1f114f1f0706dfbeb6170ac054f09beb43f0c80a84b00ddaeea7bb5b8755d5a4L24-R24), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-5e8ff5e5419ea6825f710a98d412416b2d8dbd5f47aaddec194f08800a2c7e84L2-L1), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-0149f779b6f396ad46ac0aa30e8869b9c5e3c3aeefe0abd1ef4133bd46dd7734L7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-0149f779b6f396ad46ac0aa30e8869b9c5e3c3aeefe0abd1ef4133bd46dd7734L17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-0149f779b6f396ad46ac0aa30e8869b9c5e3c3aeefe0abd1ef4133bd46dd7734L24-R24), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-de33096a2e86db360e21297ed3862e9ecdb9af347b783cb5166142e4459ac70dL7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-de33096a2e86db360e21297ed3862e9ecdb9af347b783cb5166142e4459ac70dL17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-de33096a2e86db360e21297ed3862e9ecdb9af347b783cb5166142e4459ac70dL24-R24), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-dbe373a6a2d5d6fa73231628bb70407a01134fe53995a182ec07fa02834cecb9L7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-dbe373a6a2d5d6fa73231628bb70407a01134fe53995a182ec07fa02834cecb9L17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-dbe373a6a2d5d6fa73231628bb70407a01134fe53995a182ec07fa02834cecb9L24-R24), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-1bffb047d3fcbac0e7d987b9e32b62323f777fcdb36c03e871da2af6211929c1L7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-1bffb047d3fcbac0e7d987b9e32b62323f777fcdb36c03e871da2af6211929c1L17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-1bffb047d3fcbac0e7d987b9e32b62323f777fcdb36c03e871da2af6211929c1L24-R24), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-d8f7b4d3e0ffaa6f1f28933d7c1f1fdabbc2de7157ba6a0cfbade9839d60a65dL7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-d8f7b4d3e0ffaa6f1f28933d7c1f1fdabbc2de7157ba6a0cfbade9839d60a65dL17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-d8f7b4d3e0ffaa6f1f28933d7c1f1fdabbc2de7157ba6a0cfbade9839d60a65dL24-R24), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-152d73ffee03f046a3492570905cd7629835edb8f07d548cf82abc7a4eebcf30L7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-152d73ffee03f046a3492570905cd7629835edb8f07d548cf82abc7a4eebcf30L17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-152d73ffee03f046a3492570905cd7629835edb8f07d548cf82abc7a4eebcf30L24-R24), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-934b0277f7bf93b63e85c8077d523620e546046c46a1858fde8b067d8dc6506aL7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-934b0277f7bf93b63e85c8077d523620e546046c46a1858fde8b067d8dc6506aL17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-934b0277f7bf93b63e85c8077d523620e546046c46a1858fde8b067d8dc6506aL24-R24), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-6859bfb062ab179215c29ca5ee9d2754753078ab1b0b5cc660318b1596459d81L7-R7), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-6859bfb062ab179215c29ca5ee9d2754753078ab1b0b5cc660318b1596459d81L17-R17), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-6859bfb062ab179215c29ca5ee9d2754753078ab1b0b5cc660318b1596459d81L24-R24)) * Replace the label name radius.dev/application with radapp.io/application in code comments and test data (`pkg/cli/kubernetes/logstream/stern.go`, `pkg/cli/kubernetes/portforward/application_watcher.go`, [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L284-R286), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L358-R360), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L418-R420), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L467-R469), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L511-R513), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L553-R555), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-6f1219f263ab06a1493ac76960e2ab8cbe647e83e926bff7d13988f393334f94L473-R473), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-698cbcd40aa6d9d8f2422946df2036893050befd5ba5d1cdbe413334a8a795d5L12-R14), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-698cbcd40aa6d9d8f2422946df2036893050befd5ba5d1cdbe413334a8a795d5L26-R27), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-698cbcd40aa6d9d8f2422946df2036893050befd5ba5d1cdbe413334a8a795d5L37-R39), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-3edf0da9064abf46fb57fe2156e333959343a3104599ddf78f64779deca2e074L12-R14), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-3edf0da9064abf46fb57fe2156e333959343a3104599ddf78f64779deca2e074L26-R27), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-3edf0da9064abf46fb57fe2156e333959343a3104599ddf78f64779deca2e074L39-R41), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-ec18995e697107d252ed17ccd8be4bfa5c62cd32b37b75e34379a9053cd39166L74-R79)) * Replace the label name radius.dev/resource with radapp.io/resource in test data ([link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L284-R286), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L358-R360), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L418-R420), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L467-R469), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L511-R513), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L553-R555), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-698cbcd40aa6d9d8f2422946df2036893050befd5ba5d1cdbe413334a8a795d5L12-R14), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-698cbcd40aa6d9d8f2422946df2036893050befd5ba5d1cdbe413334a8a795d5L26-R27), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-698cbcd40aa6d9d8f2422946df2036893050befd5ba5d1cdbe413334a8a795d5L37-R39), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-3edf0da9064abf46fb57fe2156e333959343a3104599ddf78f64779deca2e074L12-R14), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-3edf0da9064abf46fb57fe2156e333959343a3104599ddf78f64779deca2e074L26-R27), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-3edf0da9064abf46fb57fe2156e333959343a3104599ddf78f64779deca2e074L39-R41), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-ec18995e697107d252ed17ccd8be4bfa5c62cd32b37b75e34379a9053cd39166L74-R79)) * Replace the label name radius.dev/resource-type with radapp.io/resource-type in test data ([link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L284-R286), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L358-R360), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L418-R420), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L467-R469), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L511-R513), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-464b567399407ca08de3c0341b37b7f7a9eb047020323802dba3bc90acc63613L553-R555), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-698cbcd40aa6d9d8f2422946df2036893050befd5ba5d1cdbe413334a8a795d5L12-R14), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-698cbcd40aa6d9d8f2422946df2036893050befd5ba5d1cdbe413334a8a795d5L37-R39), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-3edf0da9064abf46fb57fe2156e333959343a3104599ddf78f64779deca2e074L12-R14), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-3edf0da9064abf46fb57fe2156e333959343a3104599ddf78f64779deca2e074L39-R41), [link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-ec18995e697107d252ed17ccd8be4bfa5c62cd32b37b75e34379a9053cd39166L74-R79)) * Replace the label name radius.dev/route-httproutes-a with radapp.io/route-httproutes-a in test data ([link](https://github.com/radius-project/radius/pull/6357/files?diff=unified&w=0#diff-6f1219f263ab06a1493ac76960e2ab8cbe647e83e926bff7d13988f393334f94L473-R473))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These labels were added back when Radius RP was namespaced as
radius.dev, we need to update them to reflect revised namespaces.AB#6518
The text was updated successfully, but these errors were encountered: