Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gh auth login command arguments #1274

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

willdavsmith
Copy link
Contributor

@willdavsmith willdavsmith commented Nov 11, 2024

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

Signed-off-by: willdavsmith <[email protected]>
@willdavsmith willdavsmith merged commit fc17439 into v0.39 Nov 11, 2024
9 checks passed
@willdavsmith willdavsmith deleted the willdavsmith/authlogin2 branch November 11, 2024 21:57
Reshrahim added a commit that referenced this pull request Nov 12, 2024
* Update docs for v0.39.0

* Add IRSA to the cloud provider table (#1262)

* Update index.md

Signed-off-by: Reshma Abdul Rahim <[email protected]>

* Update index.md

Signed-off-by: Reshma Abdul Rahim <[email protected]>

---------

Signed-off-by: Reshma Abdul Rahim <[email protected]>

* create CODEOWNERS (#1263)

Signed-off-by: Will Tsai <[email protected]>

* Update the supported clusters link in getting started guide  (#1238)

* Update docs for v0.38.0

* Update index.md

Signed-off-by: Reshma Abdul Rahim <[email protected]>

---------

Signed-off-by: Reshma Abdul Rahim <[email protected]>
Co-authored-by: Radius CI Bot <[email protected]>

* Remove broken signoff argument (#1269)

Signed-off-by: willdavsmith <[email protected]>

* Fix GH PAT scope (#1272)

Signed-off-by: willdavsmith <[email protected]>

* adding gh auth login (#1273)

Signed-off-by: willdavsmith <[email protected]>

* Fix gh auth login command (#1274)

Signed-off-by: willdavsmith <[email protected]>

* Fix GitHub auth login for upmerge workflow (#1278)

* Adding GH_TOKEN

Signed-off-by: willdavsmith <[email protected]>

* Adding Signoff

Signed-off-by: willdavsmith <[email protected]>

* Removing Signoff

Signed-off-by: willdavsmith <[email protected]>

---------

Signed-off-by: willdavsmith <[email protected]>

* Removing version info

Signed-off-by: willdavsmith <[email protected]>

---------

Signed-off-by: Reshma Abdul Rahim <[email protected]>
Signed-off-by: Will Tsai <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Will Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants