-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove codespaces and add link to k3d config #1201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Reshrahim
commented
Aug 20, 2024
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Having the k3d cluster config link is great. 🎸 |
willtsai
reviewed
Aug 30, 2024
Comment on lines
19
to
24
{{< alert title="🚀 Run in a <b>free</b> GitHub Codespace" color="primary" >}} | ||
The Radius getting-started guide can be [run **for free** in a GitHub Codespace](https://github.blog/changelog/2022-11-09-codespaces-for-free-and-pro-accounts/). Visit the following link to get started in seconds: | ||
|
||
[![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/radius-project/samples) | ||
{{< /alert >}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should comment this out for now in case we figure out a solution to enable users to leverage codespaces again?
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Signed-off-by: Reshma Abdul Rahim <[email protected]>
willtsai
reviewed
Sep 13, 2024
Signed-off-by: Will <[email protected]>
willtsai
approved these changes
Sep 13, 2024
ytimocin
added a commit
that referenced
this pull request
Sep 13, 2024
* Update docs for v0.37.0 * Update index.md (#1203) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Bump micromatch from 4.0.4 to 4.0.8 in /docs (#1210) Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.4 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.4...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <[email protected]> * Remove codespaces and add link to k3d config (#1201) * Update index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> * Update docs/content/getting-started/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> * Update index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> * Update index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> * Update index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> * Update docs/content/getting-started/index.md Signed-off-by: Will <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Will <[email protected]> * Reverting some changes Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: ytimocin <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will <[email protected]> Co-authored-by: ytimocin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This PR removed Codespaces as it is disabled for the project. We are working with the CNCF team to get it re-enabled. Also ads link to the k3d cluster config
Issue reference
Fixes: #1171