-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add envSecrets block to HowTo Custom Provider tutorial #1166
Merged
willtsai
merged 2 commits into
radius-project:v0.36
from
lakshmimsft:lakshmimsft/addenvSecrets
Jul 26, 2024
Merged
Add envSecrets block to HowTo Custom Provider tutorial #1166
willtsai
merged 2 commits into
radius-project:v0.36
from
lakshmimsft:lakshmimsft/addenvSecrets
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtsai
previously approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the addition, just one minor suggestion for clarity
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
willtsai
reviewed
Jul 26, 2024
docs/content/guides/recipes/terraform/howto-custom-provider/snippets/env-complete.bicep
Show resolved
Hide resolved
willtsai
approved these changes
Jul 26, 2024
sk593
pushed a commit
that referenced
this pull request
Aug 7, 2024
* adding envSecrets * updated per suggestion
sk593
pushed a commit
that referenced
this pull request
Aug 7, 2024
* adding envSecrets * updated per suggestion Signed-off-by: sk593 <[email protected]>
sk593
added a commit
that referenced
this pull request
Aug 13, 2024
* Update docs for v0.36.0 Signed-off-by: sk593 <[email protected]> * Update auto-generated documentation (#1151) * Autogenerate reference docs Signed-off-by: rad-ci-bot <[email protected]> * Update en-custom.txt Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: rad-ci-bot <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: rad-ci-bot <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: sk593 <[email protected]> * Add HowTo tutorial to configure Terraform Custom Provider (#1162) * add howto doc for tf custom provider config * unsaved files * update per comments * update for conflicts * extra space * extra space * further comments * capitalizing Environment * one more change --------- Signed-off-by: Lakshmi Javadekar <[email protected]> Signed-off-by: sk593 <[email protected]> * correct highlight (#1164) Signed-off-by: sk593 <[email protected]> * Update index.md (#1160) Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: sk593 <[email protected]> * Add envSecrets block to HowTo Custom Provider tutorial (#1166) * adding envSecrets * updated per suggestion Signed-off-by: sk593 <[email protected]> * removing port input in config (#1167) Signed-off-by: sk593 <[email protected]> * revert Signed-off-by: sk593 <[email protected]> * fix spellcheck Signed-off-by: sk593 <[email protected]> * Update docs/layouts/partials/hooks/body-end.html Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: sk593 <[email protected]> Signed-off-by: rad-ci-bot <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Lakshmi Javadekar <[email protected]> Co-authored-by: Radius CI Bot <[email protected]> Co-authored-by: rad-ci-bot <[email protected]> Co-authored-by: rad-ci-bot <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Lakshmi Javadekar <[email protected]>
Reshrahim
added a commit
that referenced
this pull request
Aug 16, 2024
* Update docs for v0.36.0 * Update auto-generated documentation (#1151) * Autogenerate reference docs Signed-off-by: rad-ci-bot <[email protected]> * Update en-custom.txt Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: rad-ci-bot <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: rad-ci-bot <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * Add HowTo tutorial to configure Terraform Custom Provider (#1162) * add howto doc for tf custom provider config * unsaved files * update per comments * update for conflicts * extra space * extra space * further comments * capitalizing Environment * one more change --------- Signed-off-by: Lakshmi Javadekar <[email protected]> * correct highlight (#1164) * Update index.md (#1160) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add envSecrets block to HowTo Custom Provider tutorial (#1166) * adding envSecrets * updated per suggestion * removing port input in config (#1167) * Fix upmerge workflow error when no changes (#1192) Signed-off-by: Brooke Hamilton <[email protected]> * addressing comments Signed-off-by: Vishwanath Hiremath <[email protected]> * addressing comments Signed-off-by: Vishwanath Hiremath <[email protected]> --------- Signed-off-by: rad-ci-bot <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Lakshmi Javadekar <[email protected]> Signed-off-by: Brooke Hamilton <[email protected]> Signed-off-by: Vishwanath Hiremath <[email protected]> Co-authored-by: Radius CI Bot <[email protected]> Co-authored-by: rad-ci-bot <[email protected]> Co-authored-by: rad-ci-bot <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Lakshmi Javadekar <[email protected]> Co-authored-by: Brooke Hamilton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Add envSecrets block to HowTo Custom Provider tutorial