Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for 915: account for different use cases of median #916

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

keflavich
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (7bc6bac) to head (4d7182f).
Report is 4 commits behind head on master.

Current head 4d7182f differs from pull request most recent head 8486580

Please upload reports for the commit 8486580 to get more accurate results.

Files Patch % Lines
spectral_cube/spectral_cube.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   79.94%   79.84%   -0.10%     
==========================================
  Files          24       24              
  Lines        6013     6024      +11     
==========================================
+ Hits         4807     4810       +3     
- Misses       1206     1214       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keflavich
Copy link
Contributor Author

There's a bug in warn_slow: it should inspect the function being called to see whether it accepts a how keyword. Presently, it's warning users to use the how keyword even if they're using DaskSpectralCubes

@keflavich
Copy link
Contributor Author

the last two commits might've been a red herring; I don't think dask is raising the wrong error message.

…n-dask keywords, likely caused by wrong inheritance order in the composite (the mixin is overridden by the base SpectralCube)
@e-koch
Copy link
Contributor

e-koch commented Oct 18, 2024

Merging. Test failures are unrelated.

@e-koch e-koch merged commit cb8dfbe into radio-astro-tools:master Oct 18, 2024
4 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants