Allow general filter use instead of just median filters #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keflavich
force-pushed
the
general_filters
branch
2 times, most recently
from
6dc01dc
to
e6bdd99
Compare
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
==========================================
+ Coverage 77.90% 77.99% +0.09%
==========================================
Files 24 24
Lines 5861 5876 +15
==========================================
+ Hits 4566 4583 +17
+ Misses 1295 1293 -2
Continue to review full report at Codecov.
|
|
Ready for review This PR basically just allows other filters to be used. I needed this for some reason I can't remember recently.... I think I wanted a percentile filter or something? |
e-koch
requested changes
Jun 13, 2022
Co-authored-by: Eric Koch <[email protected]> Update spectral_cube/dask_spectral_cube.py Co-authored-by: Eric Koch <[email protected]> Update spectral_cube/spectral_cube.py Co-authored-by: Eric Koch <[email protected]> Update spectral_cube/spectral_cube.py Co-authored-by: Eric Koch <[email protected]> Update spectral_cube/spectral_cube.py Co-authored-by: Eric Koch <[email protected]> Update spectral_cube/spectral_cube.py Co-authored-by: Eric Koch <[email protected]> Update spectral_cube/spectral_cube.py Co-authored-by: Eric Koch <[email protected]> Update spectral_cube/spectral_cube.py Co-authored-by: Eric Koch <[email protected]> Update spectral_cube/dask_spectral_cube.py Co-authored-by: Eric Koch <[email protected]> Update spectral_cube/dask_spectral_cube.py Co-authored-by: Eric Koch <[email protected]> Update spectral_cube/dask_spectral_cube.py Co-authored-by: Eric Koch <[email protected]>
keflavich
force-pushed
the
general_filters
branch
from
75684ec
to
fdbfcd6
Compare
Co-authored-by: Eric Koch <[email protected]>
Co-authored-by: Eric Koch <[email protected]>
e-koch
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a nicer way to inherit the docstrings?