-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid redundant full-cube-passes when region submasking #801
Avoid redundant full-cube-passes when region submasking #801
Conversation
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
==========================================
- Coverage 77.94% 77.90% -0.04%
==========================================
Files 24 24
Lines 5853 5856 +3
==========================================
Hits 4562 4562
- Misses 1291 1294 +3
Continue to review full report at Codecov.
|
a3fd542
to
b62dda8
Compare
This produces WCS mismatches only on windows. That seems unlikely; either this is a problem with the test grid or a genuine problem with how WCS behaves on windows machines? |
Ready for final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small docs change. Otherwise looks good!
Co-authored-by: Eric Koch <[email protected]>
Region sub-masking has been using
minimal_subcube
, which shouldn't be necessary b/c we already downselect to the minimal bounding box.Also, it was creating 3D masks when only 2D is needed - the broadcasting might therefore not have been done lazily.