Added stokes_data public method #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously not possible to cleanly access the underlying data of a `StokesSpectralCube`, which only had the `_stokes_data` method. This commit implements a simple `StokesSpectralCube.stokes_data` method for public access.
keflavich
approved these changes
Oct 5, 2021
For some reason, reshaping the array then running map_blocks leads to memory issues when dealing with Numpy memory mapped arrays, e.g. with FITS files. This new approach avoids reshaping the array at all.
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
==========================================
+ Coverage 77.55% 77.57% +0.01%
==========================================
Files 24 24
Lines 5775 5783 +8
==========================================
+ Hits 4479 4486 +7
- Misses 1296 1297 +1
Continue to review full report at Codecov.
|
Avoid memory issues when computing statistics
…endian data and provides no performance improvements
Don't use bottleneck in statistics()
As per the second suggestion in radio-astro-tools#750 - the Stokes data can now be accessed via cube['I'], cube['Q'] etc. Assigning new keys is not yet supported and will throw NotImplementedError if attempted.
|
I'm fine with this; will merge soon if there are no objections |
Remove if statement that stops tox from running tests
|
@Kitchi or @preshanth -- The tests are now fixed from #759. Can you rebase this branch? |
|
I just did @e-koch . Hope that is enough |
It was previously not possible to cleanly access the underlying data of a `StokesSpectralCube`, which only had the `_stokes_data` method. This commit implements a simple `StokesSpectralCube.stokes_data` method for public access.
As per the second suggestion in radio-astro-tools#750 - the Stokes data can now be accessed via cube['I'], cube['Q'] etc. Assigning new keys is not yet supported and will throw NotImplementedError if attempted.
|
Windows test failure is unrelated and known from #759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously not possible to cleanly access the underlying data of
a
StokesSpectralCube, which only had the_stokes_datamethod. Thiscommit implements a simple
StokesSpectralCube.stokes_datamethod forpublic access.
This implements the first suggestion in #750