Add 'beam' attribute to 1dSpectrum #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since slices from regular cubes can need beam information
keflavich
force-pushed
the
beam_beams_spectra
branch
from
ca2c621
to
6778b4c
Compare
Conflicts: docs/spectral_extraction.rst
keflavich
added a commit
that referenced
this pull request
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a cleaner way to do this, e.g., split out 1DSpectrum and VaryingSpatialResolution1DSpectrum, but for now we're taking the quick & easy & dirty approach.