Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Keep full 3D WCS objects for LDOs #395

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

WIP: Keep full 3D WCS objects for LDOs #395

wants to merge 12 commits into from
+247 −30

Commits on Jul 4, 2017

  1. slice the third axis, don't drop it

    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    f3a72dc View commit details
    Browse the repository at this point in the history

  2. add a new tool to "drop" an axis by slicing it to 1 pixel wide

    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    14f9186 View commit details
    Browse the repository at this point in the history

  3. bugfix because I indexed the WCS incorrectly, and first test...

    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    ab2be8c View commit details
    Browse the repository at this point in the history

  4. used tests to debug new tool

    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    bec7384 View commit details
    Browse the repository at this point in the history

  5. improve test coverage and fix another edge case (literally - the end 

    case)
    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    f901a40 View commit details
    Browse the repository at this point in the history

  6. start dealing with some more error cases and move the dropped axis to 

    the end
    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    95f5eba View commit details
    Browse the repository at this point in the history

  7. working through some more test cases

    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    4176dd8 View commit details
    Browse the repository at this point in the history

  8. make the wrapper do something sensible if a smaller array is passed than 

    wcs_pix2world allows (so if you've 'dropped' a dimension, allow indexing
with ndim-1 coordinates)
    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    d67854d View commit details
    Browse the repository at this point in the history

  9. add some more tests that are failing. For some reason, the new slicing 

    operation makes a non-self-consistent WCS object, i.e., one where
`wcs.naxis != wcs.wcs.naxis`, which is supposed to be impossible, and
unfortunately is beyond my immediate capability to debug because that
part is not written in python
    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    acffbdb View commit details
    Browse the repository at this point in the history

  10. fixed naxis disagreement issue

    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    2322ecb View commit details
    Browse the repository at this point in the history

  11. add some debug statements (to be removed eventually) and fix the NAXIS 

    inserting
    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    9b1b5e8 View commit details
    Browse the repository at this point in the history

  12. minor whitespace

    @keflavich
    keflavich committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    8254a7e View commit details
    Browse the repository at this point in the history