Make SpectralCube operate more like a numpy array in some ways #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keflavich
force-pushed
the
provide_base
branch
2 times, most recently
from
a207918
to
78b8dfc
Compare
spectral cubes, understanding that they are memmaps. For a related reason, lower dimensional slices should return _data[view], not filled_data[view], BUT this doesn't provide the right functionality so we want lower dimensional objects to implement their own cubelike masking
keflavich
force-pushed
the
provide_base
branch
from
78b8dfc
to
c6097a1
Compare
|
assuming this passes, I'll merge it, and the lower-dimensional masking will get put off to a different issue |
keflavich
added a commit
that referenced
this pull request
Aug 15, 2015
Make SpectralCube operate more like a numpy array in some ways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
spectral cubes, understanding that they are memmaps.
not filled_data[view], BUT this doesn't provide the right functionality so we
want lower dimensional objects to implement their own cubelike masking
The TODO list: