This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Remote
component subverts type checking
#1798
Labels
Comments
geigerzaehler
pushed a commit
that referenced
this issue
Apr 28, 2021
The API now provides the branch a commit belongs to. This partially reverts #1717. The issue was not discovered because of disabled type checking due to #1798. We address this by not using the `Remote` component The motivation for #1717 was to gracefully handle commits without branches and not panic. We accomplish this by returning the (possibly empty) list of all branches and only showing the first branch (if present) in the UI. Fixes #1793 Signed-off-by: Thomas Scholtes <[email protected]>
Merged
Merged
16 tasks
geigerzaehler
added a commit
that referenced
this issue
Oct 6, 2021
See #1798 Signed-off-by: Thomas Scholtes <[email protected]>
geigerzaehler
added a commit
that referenced
this issue
Oct 6, 2021
See #1798 Signed-off-by: Thomas Scholtes <[email protected]>
rudolfs
pushed a commit
that referenced
this issue
Oct 7, 2021
See #1798 Signed-off-by: Thomas Scholtes <[email protected]>
Kaihuang724
added
bug
Something isn't working
tech-debt
and removed
bug
Something isn't working
labels
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
At the moment it is not possible to have type generic components in svelte (sveltejs/language-tools#442). This means that the
Remote
component has to use theany
type for data passed to its slots. As a result, slots are not type-checked.Consider the following code
This will compile although
Foo
does not have abar
property.To address this I would suggest to avoid the
Remote
component and implement it by hand every time is used. In the example above this would result inThis will fail to type check.
The
Remote
component is quite slim and in most cases only a small part of theRemote
functionality is used. I think it’s justifiable to replace it with hand-written code.The text was updated successfully, but these errors were encountered: