Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dir.props: Update mono build to target 4.6 instead of 4.5.1
This also fixes the build for mono/osx. The build would break because mcs was getting duplicate references like: 1. /reference:/Users/ankit/dev/misc/lib/mono/4.5-api/Facades/System.IO.dll 2. /reference:/Users/ankit/.nuget/packages/System.IO/4.0.10/ref/dotnet/System.IO.dll Ref(1) was resolved because of `ImplictlyExpandDesignTimeFacades`, and the latter came from the task `PrereleaseResolveNugetPackages`. This task reads from the project.lock.json (generated by `dnu restore`), and for 4.5.1 case these assemblies were marked to have the assemblies from the package be used. This is not the case for 4.6, where these assemblies instead have entries like `ref/net45/_._`, effectively suggesting that the assembly should be resolved from the GAC instead. There are newer version of these package (like System.IO) available, which seem to fix this, but it seems to be in flux. Instead, we just target 4.6 completely for mono builds, which is the same as the build for Windows and CoreCLR. This also means that you cannot use mono < 4.4.x to build, since .net 4.6 API will become available only with mono 4.4.0 . But that is OK as we cannot really get a useful build with the older mono anyway. This does not affect CoreCLR builds that use mono host.
- Loading branch information