Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-ve mode #3252

Merged
merged 7 commits into from
Nov 19, 2024
Merged

non-ve mode #3252

merged 7 commits into from
Nov 19, 2024

Conversation

andre-merzky
Copy link
Member

This adresses the issue discussed here: radical-cybertools/radical.modules#2 (comment)

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.81%. Comparing base (751ec63) to head (e418b38).
Report is 8 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/pilot/agent/agent_0.py 0.00% 3 Missing ⚠️
src/radical/pilot/pmgr/launching/base.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3252      +/-   ##
==========================================
- Coverage   42.82%   42.81%   -0.02%     
==========================================
  Files          97       97              
  Lines       11245    11248       +3     
==========================================
  Hits         4816     4816              
- Misses       6429     6432       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides couple comments the rest looks good

src/radical/pilot/agent/bootstrap_0.sh Outdated Show resolved Hide resolved
src/radical/pilot/agent/bootstrap_0.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@andre-merzky andre-merzky merged commit 159aece into devel Nov 19, 2024
25 of 31 checks passed
@andre-merzky andre-merzky deleted the feature/non_ve_mode branch November 19, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants