Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move rm init #3081

Merged
merged 3 commits into from
Nov 6, 2023
Merged

move rm init #3081

merged 3 commits into from
Nov 6, 2023

Conversation

andre-merzky
Copy link
Member

alternative implementation to #3079

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 43.99%. Comparing base (a3a599b) to head (0ab8fab).
Report is 1579 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/pilot/session.py 53.33% 7 Missing ⚠️
src/radical/pilot/agent/agent_0.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3081      +/-   ##
==========================================
- Coverage   44.00%   43.99%   -0.02%     
==========================================
  Files          96       96              
  Lines       10569    10574       +5     
==========================================
+ Hits         4651     4652       +1     
- Misses       5918     5922       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

p.s. confirm that it works as expected on Frontier

$ grep -r "RM init from" ./*
./agent_executing.0000.log:1699044505.169 : agent_executing.0000 : 10376 : 140735520786176 : DEBUG    : RM init from registry
./agent_scheduling.0000.log:1699044505.194 : agent_scheduling.0000 : 10400 : 140735520786176 : DEBUG    : RM init from registry
./rp.session.login07.matitov.019664.0000.log:1699044494.285 : rp.session.login07.matitov.019664.0000 : 10099 : 140737179934528 : DEBUG    : RM init from scratch

@mtitov mtitov merged commit 9ae9fb2 into devel Nov 6, 2023
30 checks passed
@mtitov mtitov deleted the fix/rm_init_2 branch November 6, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants