Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated paths for Proxy and Session #3073

Merged
merged 12 commits into from
Oct 27, 2023
Merged

updated paths for Proxy and Session #3073

merged 12 commits into from
Oct 27, 2023

Conversation

mtitov
Copy link
Contributor

@mtitov mtitov commented Oct 26, 2023

Fixes #3072

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #3073 (ed12a52) into devel (04fdbd3) will increase coverage by 0.07%.
The diff coverage is 50.00%.

❗ Current head ed12a52 differs from pull request most recent head e2a3817. Consider uploading reports for the commit e2a3817 to get more accurate results

@@            Coverage Diff             @@
##            devel    #3073      +/-   ##
==========================================
+ Coverage   43.90%   43.98%   +0.07%     
==========================================
  Files          96       96              
  Lines       10563    10568       +5     
==========================================
+ Hits         4638     4648      +10     
+ Misses       5925     5920       -5     
Files Coverage Δ
src/radical/pilot/proxy.py 16.96% <33.33%> (ø)
src/radical/pilot/session.py 50.34% <60.00%> (+1.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mtitov mtitov marked this pull request as ready for review October 27, 2023 00:39
@mtitov mtitov self-assigned this Oct 27, 2023
Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AymenFJA , @mtitov for catching and fixing this!

One nitpick:

if not foo:
   bar

was changed several times to

if not foo:
    bar
else:
    buz

I would suggest to switch to

if foo:
    buz
else:
    bar

to lower the mental load on reading the code.

Copy link
Contributor

@AymenFJA AymenFJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mtitov LGTM, as well.

@mtitov mtitov enabled auto-merge October 27, 2023 16:24
@mtitov mtitov disabled auto-merge October 27, 2023 16:41
@mtitov mtitov merged commit 2be0544 into devel Oct 27, 2023
29 checks passed
@mtitov mtitov deleted the fix/issue_3072 branch October 27, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client_sandbox path setup is not behaving as expected
3 participants