Fix/issue 509 #513
Closed
Fix/issue 509 #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-merzky
approved these changes
Dec 2, 2020
|
|
||
| self._log.debug('Connection State %s channel state %s' | ||
| % (mq_connection.is_open, | ||
| mq_channel.is_open)) |
There was a problem hiding this comment.
I would suggest to disable that message - it's on a hot code path. OTOH, it's DEBUG level, and we should not encourage to run DEBUG as default level either. Hmm, so probably ok... :-)
mturilli
reviewed
Dec 3, 2020
| @@ -22,6 +22,8 @@ | |||
|
|
|||
| from .wfprocessor import WFprocessor | |||
|
|
|||
| pika.connection.Parameters.DEFAULT_HEARTBEAT_INTERVAL = 0 | |||
| pika.connection.Parameters.DEFAULT_HEARTBEAT_TIMEOUT = 0 | |||
|
|
|||
There was a problem hiding this comment.
Do we want that to be the default behavior for EnTK and RBMQ? Do we have issues only with one user and one machine or is the heartbeat_interval going to be a more general issue? If the former, then should we keep the default as it has been so far and enable setting the interval/timeout to a specific value via env variables?
|
Closing this PR as there is an easy workaround |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to take care of cases like issue #509. I still to find a proper fix for that one.